From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] eww improvements Date: Tue, 25 Jun 2013 09:07:34 +0300 Organization: JURTA Message-ID: <87k3lihpax.fsf@mail.jurta.org> References: <8738s8ix1k.fsf@kanis.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1372140906 26848 80.91.229.3 (25 Jun 2013 06:15:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Jun 2013 06:15:06 +0000 (UTC) Cc: Lars Grunewaldt , Emacs Development List To: Ivan Kanis Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 25 08:15:03 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrMWs-0006WW-RF for ged-emacs-devel@m.gmane.org; Tue, 25 Jun 2013 08:15:02 +0200 Original-Received: from localhost ([::1]:36600 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrMWs-0004m5-CU for ged-emacs-devel@m.gmane.org; Tue, 25 Jun 2013 02:15:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrMWm-0004gL-Db for emacs-devel@gnu.org; Tue, 25 Jun 2013 02:14:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrMWk-0001Bn-Tj for emacs-devel@gnu.org; Tue, 25 Jun 2013 02:14:56 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:41174 helo=ps18281.dreamhostps.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrMWk-0001B5-Nd for emacs-devel@gnu.org; Tue, 25 Jun 2013 02:14:54 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 7AEEE258B9E91C; Mon, 24 Jun 2013 23:14:53 -0700 (PDT) In-Reply-To: <8738s8ix1k.fsf@kanis.fr> (Ivan Kanis's message of "Sun, 23 Jun 2013 18:58:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 69.163.218.105 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161008 Archived-At: > @@ -313,6 +319,7 @@ > (define-key map "p" 'eww-previous-url) > (define-key map "u" 'eww-up-url) > (define-key map "t" 'eww-top-url) > + (define-key map "w" 'eww-browse-with-external-browser) Please bind the keybinding "w" to the command that copies the current URL from `eww-current-url' to the kill ring because "w" is used by similar commands `Info-copy-current-node-name' in Info and `dired-copy-filename-as-kill' in Dired. Note that both commands have the word "copy" in their names, not "yank". So to reduce confusion please rename `eww-yank-page-url' to the name with the word "copy" such as `eww-copy-current-url', and then bind both `eww-copy-current-url' and `shr-copy-url' to "w". As for where to bind `eww-browse-with-external-browser' what do you think about the keybinding "&" (with the mnemonics of an async command)? > I have attached my wget.el. I sent the author an e-mail to see if he > would sign the FSF paper work to include it in Emacs. wget.el is a very good package, I welcome its inclusion into Emacs. For the examples of the integration of wget with eww, see the files w3-wget.el and w3m-wget.el. A similar file could be created with the name eww-wget.el.