unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* display keywords in package.el
@ 2013-12-09 16:01 Ted Zlatanov
  2013-12-11 11:13 ` Jambunathan K
  0 siblings, 1 reply; 10+ messages in thread
From: Ted Zlatanov @ 2013-12-09 16:01 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

The attached patch will:

- factor out the button creation to a new `package-make-button' function

- insert a list of clickable keywords for any package with a Keywords
  header (it must be in the archive-contents extras; GNU ELPA has it and
  other ELPAs like MELPA may wish to follow suit)

- clicking the keyword runs `(finder-list-matches "keyword")' which is
  usually what the user wants.

TODO: `(finder-list-matches "keyword")' only looks at the local files,
if I understand finder.el correctly.  It should be fixed to also display
the remote packages.  I don't think it's required for this patch,
though, it can be done in a followup patch.

Let me know if you see any problems.  I'll commit otherwise.

Thanks
Ted


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: package-describe-keywords.patch --]
[-- Type: text/x-diff, Size: 2949 bytes --]

=== modified file 'lisp/emacs-lisp/package.el'
--- lisp/emacs-lisp/package.el	2013-11-20 21:01:00 +0000
+++ lisp/emacs-lisp/package.el	2013-12-09 15:51:59 +0000
@@ -1353,7 +1353,9 @@
          (reqs (if desc (package-desc-reqs desc)))
          (version (if desc (package-desc-version desc)))
          (archive (if desc (package-desc-archive desc)))
-         (homepage (if desc (cdr (assoc :url (package-desc-extras desc)))))
+         (extras (and desc (package-desc-extras desc)))
+         (homepage (cdr (assoc :url extras)))
+         (keywords (cdr (assoc :keywords extras)))
          (built-in (eq pkg-dir 'builtin))
          (installable (and archive (not built-in)))
          (status (if desc (package-desc-status desc) "orphan"))
@@ -1392,15 +1394,10 @@
            (insert (capitalize status))
 	   (insert " from " (format "%s" archive))
 	   (insert " -- ")
-	   (let ((button-text (if (display-graphic-p) "Install" "[Install]"))
-		 (button-face (if (display-graphic-p)
-				  '(:box (:line-width 2 :color "dark grey")
-					 :background "light grey"
-					 :foreground "black")
-				'link)))
-	     (insert-text-button button-text 'face button-face 'follow-link t
-				 'package-desc desc
-				 'action 'package-install-button-action)))
+           (package-make-button
+            "Install"
+            'action 'package-install-button-action
+            'package-desc desc))
 	  (t (insert (capitalize status) ".")))
     (insert "\n")
     (insert "    " (propertize "Archive" 'font-lock-face 'bold)
@@ -1433,6 +1430,15 @@
       (insert "   " (propertize "Homepage" 'font-lock-face 'bold) ": ")
       (help-insert-xref-button homepage 'help-url homepage)
       (insert "\n"))
+    (when keywords
+      (insert "   " (propertize "Keywords" 'font-lock-face 'bold) ": ")
+      (dolist (k keywords)
+        (package-make-button
+         k
+         'package-keyword k
+         'action 'package-keyword-button-action)
+        (insert " "))
+      (insert "\n"))
     (let* ((all-pkgs (append (cdr (assq name package-alist))
                              (cdr (assq name package-archive-contents))
                              (let ((bi (assq name package--builtins)))
@@ -1503,6 +1509,20 @@
       (revert-buffer nil t)
       (goto-char (point-min)))))
 
+(defun package-keyword-button-action (button)
+  (let ((pkg-keyword (button-get button 'package-keyword)))
+    (finder-list-matches pkg-keyword)))
+
+(defun package-make-button (text &rest props)
+  (let ((button-text (if (display-graphic-p) text (concat "[" text "]")))
+        (button-face (if (display-graphic-p)
+                         '(:box (:line-width 2 :color "dark grey")
+                                :background "light grey"
+                                :foreground "black")
+                       'link)))
+    (apply 'insert-text-button button-text 'face button-face 'follow-link t
+           props)))
+
 \f
 ;;;; Package menu mode.
 


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-12-16 14:26 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-09 16:01 display keywords in package.el Ted Zlatanov
2013-12-11 11:13 ` Jambunathan K
2013-12-11 19:04   ` Ted Zlatanov
2013-12-11 19:12     ` Jambunathan K
2013-12-12  3:34     ` Stefan Monnier
2013-12-12 15:38       ` Ted Zlatanov
2013-12-14 20:03         ` Ted Zlatanov
2013-12-16  0:19           ` T.V. Raman
2013-12-16  3:50             ` Stefan Monnier
2013-12-16 14:26             ` Ted Zlatanov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).