unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: phillip.lord@newcastle.ac.uk (Phillip Lord)
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: pre-command-hook with input methods
Date: Wed, 11 Feb 2015 17:17:19 +0000	[thread overview]
Message-ID: <87k2zopduo.fsf@newcastle.ac.uk> (raw)
In-Reply-To: <878ug53ljk.fsf@newcastle.ac.uk> (Phillip Lord's message of "Tue,  10 Feb 2015 14:09:51 +0000")

Phillip Lord <phillip.lord@newcastle.ac.uk> writes:
>>> The other possibility is not to have an interaction hook but to have a
>>> "the buffer has just changed in some way that is liable to cause a
>>> redisplay"-hook. I don't know that this would be better.  I throw it out
>>> as a possibility, depending on which is easier.
>>
>> Then maybe the (new in 24.4) pre-redisplay-function could be used
>> for that.  Something like
>>
>>     (add-function :before pre-redisplay-function
>>                   (lambda (wins)
>>                     (if (or (eq t wins)
>>                             (memq <mybuffer> (mapcar #'window-buffer wins)))
>>                         <take-foo-down>)))
>>
>> Of course, this will require some care, since a redisplay happens
>> probably right after you've set things up (i.e. before you start
>> waiting for user input), and you don't want *that* redisplay to trigger
>> the <take-foo-down>.
> [snip]
>
> Still, it's there now, so I will give it a go. But having the
> input-event-hook might be better.


Given this a quick go. I was a bit confused because it's
"pre-redisplay-function" and not "pre-redisplay-functions", so I spent a
while using add-hook (didn't have your email to hand at the time).

Once I fixed that, I found that pre-redisplay-function gets called an
awful lot. It's very hard for me to work out why, because all my
debugging techniques for emacs involve some output to screen (i.e.
redisplay!).

For completion purposes though, it does look like pre-redisplay-function
is going to trigger far too often.

I'll try advising the input-method next!

Phil



  reply	other threads:[~2015-02-11 17:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 13:28 pre-command-hook with input methods Phillip Lord
2015-02-05 20:19 ` Stefan Monnier
2015-02-06 13:55   ` Phillip Lord
2015-02-06 15:17     ` Stefan Monnier
2015-02-06 15:45       ` Phillip Lord
2015-02-06 23:58         ` Stefan Monnier
2015-02-09 10:47           ` Phillip Lord
2015-02-09 14:41             ` Stefan Monnier
2015-02-09 15:30               ` Phillip Lord
2015-02-09 16:13                 ` Stefan Monnier
2015-02-10 14:09                   ` Phillip Lord
2015-02-11 17:17                     ` Phillip Lord [this message]
2015-02-11 19:21                       ` Stefan Monnier
2015-02-12 10:27                         ` Phillip Lord
2015-05-25 22:52                     ` Stefan Monnier
2015-05-27 16:03                       ` Phillip Lord
2015-05-27 19:45                         ` Stefan Monnier
2015-05-27 21:54                           ` Phillip Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2zopduo.fsf@newcastle.ac.uk \
    --to=phillip.lord@newcastle.ac.uk \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).