From: Lars Ingebrigtsen <larsi@gnus.org>
To: Alan Third <alan@idiocy.org>
Cc: 1948@debbugs.gnu.org, Peter Tury <tury.peter@gmail.com>,
emacs-devel@gnu.org
Subject: Re: bug#1948: confusion and bug in dabbrev.el
Date: Mon, 29 Feb 2016 15:18:43 +1100 [thread overview]
Message-ID: <87k2loywrg.fsf@gnus.org> (raw)
In-Reply-To: <m2d1sj518u.fsf@galloway.idiocy.org> (Alan Third's message of "Sat, 30 Jan 2016 01:01:37 +0000")
Alan Third <alan@idiocy.org> writes:
> I think I've got a fix for this.
>
> The problem is that dabbrev--substitute-expansion alters EXPANSION
> before using it in the substitution, but dabbrev-expand has no idea that
> it's done this, so it assumes the unaltered EXPANSION is still valid and
> saves it.
>
> The patch makes dabbrev--substitute-expansion return EXPANSION, and
> dabbrev-expand saves that version instead.
>
> I considered making a new function to remove the whitespace and using it
> in both dabbrev-expand and dabbrev--substitute-expansion, but returning
> the value actually used strikes me as safer, in case anything else is
> done to it.
If I understand the code correctly, this looks like a good fix to me.
Could you resubmit it with the test case you sent earlier as one patch?
Also I see that we have a copyright disclaimer on file for your work.
Is that sufficient to accept code into Emacs? (I'm asking the other
Emacs hackers here...)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-02-29 4:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b5accf970901181137g45f24159pa31b6b0b7a8c0fec@mail.gmail.com>
2012-09-12 19:22 ` bug#1948: confusion and bug in dabbrev.el Fred
[not found] ` <m2mvse72c2.fsf@galloway.idiocy.org>
[not found] ` <m2d1t97drh.fsf@galloway.idiocy.org>
2016-01-30 1:01 ` Alan Third
2016-01-30 2:00 ` Drew Adams
2016-01-30 11:59 ` Alan Third
2016-01-30 12:25 ` Eli Zaretskii
2016-01-30 17:37 ` Drew Adams
2016-02-29 4:18 ` Lars Ingebrigtsen [this message]
2016-03-01 3:16 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2loywrg.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=1948@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
--cc=tury.peter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).