From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: vc-state and unregistered Date: Sun, 24 Apr 2016 20:13:26 +0200 Message-ID: <87k2jmzxh5.fsf@gmx.de> References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87bn57otja.fsf_-_@gmx.de> <515b3451-820d-ad50-8c98-d0330a0f4266@yandex.ru> <87lh4arpbg.fsf@gmx.de> <87ega2rodp.fsf@gmx.de> <87vb37ury1.fsf@gmx.de> <87potfuqdt.fsf@gmx.de> <557a2987-39e8-051e-55fd-678bc01a6a40@yandex.ru> <87lh43upd9.fsf@gmx.de> <80b86343-9324-1de0-e66c-a02e80467740@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461521655 8154 80.91.229.3 (24 Apr 2016 18:14:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Apr 2016 18:14:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 24 20:14:02 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1auOXh-0004Mv-4o for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2016 20:14:01 +0200 Original-Received: from localhost ([::1]:56170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auOXg-0006C7-81 for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2016 14:14:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auOXG-00061K-35 for emacs-devel@gnu.org; Sun, 24 Apr 2016 14:13:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auOXB-00008g-2X for emacs-devel@gnu.org; Sun, 24 Apr 2016 14:13:33 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:52157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auOXA-00008X-PX for emacs-devel@gnu.org; Sun, 24 Apr 2016 14:13:28 -0400 Original-Received: from detlef.gmx.de ([79.195.30.210]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LiTJE-1bQPtr2tBM-00cdbG; Sun, 24 Apr 2016 20:13:27 +0200 In-Reply-To: <80b86343-9324-1de0-e66c-a02e80467740@yandex.ru> (Dmitry Gutov's message of "Sun, 24 Apr 2016 20:35:47 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:D1pJhKiFdeRpJtQJIkipO787NilqzhNJeHcHDPbE4QtAoLDAG0W 9EVmbdU4B4ZS4wCuyCZ3ZmJ69e+tyZFCNt4M1zLq6iXMrb+a4PblJgVLRWheQfXvY3iVswq wahWf9vyqLxb0QGT57WpfSKTSUh2ob5zBglKqjAP2lmi38N9c5R8dPtT1NT4umG0azmsFnY cWsrbggSvTlwVT30z4OpA== X-UI-Out-Filterresults: notjunk:1;V01:K0:OIz8jebtlc4=:2i9JT7rBz9NUqwDyO6UpeJ U3WGmx/MakioMnEYZn5bXnos04ps6MOlbZGMNOMc1eSZRb5RJRLEZptqrKCbIKjmek627IRS4 xDohlFC4H78cIN0TyQ92uyKf39P0gax+6yZhWq2MMcFS5qmX1sOzR+tPAGPTEaL64AHlWz8UH mAPb9mRGbheHDy1TtnK9XQTzo+60nUY+kzHIQLYl9sF6WH/KPk0hMiYXIXi4dyJh9VxD97s0f xwAWyGiGgmXw+NaRNGE16gciudiRBKC4RKuqmZD5t3xx4CaPaoGuTEs4lqLmkeuKmV5YB4nRt RAxCsjCuLZcXNe+JBYVH4kSKoFDEBMInQoZaHEduiHKWtEQvEG/EvHQa7cwtzU8pfa8tOVAN5 a4IR2I6J+F5TfcbxQbo/HxDCNQQuMAcMtuQs/SMlsWCokQTfaR+DmjFt4M5Gj7v/46yjmg15E rrBSiHGrFD4stioWQBCiSDtAK1E8+VM5GC2W+MSQZ0I4yIhKDG3xIvT5wqQVbsDHG6jRm+m3Q VT9As06JRz4jbCsqT0vPtpQBiyWgN1KsYQrNQcrRGWFg8YAl39VFXFo4sXqqjQBZTFDFhlE2Q m2U8dcJqmrAC3kUKIoyBZ8uMkiCatY+UCN2qRMvJEvJEv87zwv3sQBCJ1KgLXtrT9Ggi+oZ/r Gh6JOceAqf20mwBnVsb1INckrzDB6soNdfdfJesNycFC2RD2NOpwjo6zXE+gy6VVooW1iGNYp +h7CI5/+gYiofj+gn2Os0gIsQiPtES2A0mmcx6YiihT7jZiz4JTDLXcBuz96LN3Pt+13jyS6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203271 Archived-At: Dmitry Gutov writes: >> Pls show me the bugs, I might have introduced. > > As far as bugs go, here's one: you never return nil from vc-state > anymore. Try evaluating: > > (progn > (vc-file-clearprops buffer-file-name) > (vc-state buffer-file-name 'CVS)) See the docstring of vc-state: "A return of nil from this function means we have no information on the status of this file." I would expect this for files which are located in a directory not under version control. None of the tests in vc-tests.el cover this case. > And if the goal is to always return non-nil (which would be a change > to the documented behavior), there is an easier way to do that than > checking (vc-registered file), like: I haven't said that my changes are perfect. But we differ in the understanding of the API. Best regards, Michael.