From: phillip.lord@russet.org.uk (Phillip Lord)
To: Drew Adams <drew.adams@oracle.com>
Cc: emacs-devel@gnu.org
Subject: Re: Why are the tests byte-compiled
Date: Fri, 17 Jun 2016 16:02:53 +0100 [thread overview]
Message-ID: <87k2hn26zm.fsf@russet.org.uk> (raw)
In-Reply-To: <c3efc058-4a9d-4196-a171-66e4897c4def@default> (Drew Adams's message of "Wed, 15 Jun 2016 14:55:29 -0700 (PDT)")
Drew Adams <drew.adams@oracle.com> writes:
>> I'm just trying to write some tests, and I get an error like this.
>>
>> Test open-this-file backtrace:
>> #[nil "\306\307!\310\311\216\n\312P\313\314!\315\216\316\314\310
>> ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
>>
>> Which is pretty useless for debugging. On the other hand, if I launch
>> the erts using the same command as the makefile uses but directly on the
>> source file (i.e. not byte compiled) then I get.
>>
>> Test open-this-file backtrace:
>> (let ((file (concat vc-git-tests-data-dir "file1.txt")) (git-dir (ge
>> (setq value-0 (let ((file (concat vc-git-tests-data-dir "file1.txt")
>>
>> which is useful.
>>
>> Conclusion: the emacs tests should not be byte-compiled. Or am I
>> missing something?
>
> Backtraces include byte-code for code that was compiled. They
> should not. Rather, it should at least be possible for a user
> or a program to elide the byte-code in a backtrace.
Sure, but in this case the byte-code hides everything of use. I can't
see any reason *why* they are byte compiled.
Phil
next prev parent reply other threads:[~2016-06-17 15:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 20:23 Why are the tests byte-compiled Phillip Lord
2016-06-15 21:55 ` Drew Adams
2016-06-17 15:02 ` Phillip Lord [this message]
2016-06-17 15:13 ` Drew Adams
2016-06-17 15:25 ` Phillip Lord
-- strict thread matches above, loose matches on Subject: below --
2016-06-26 5:18 Noam Postavsky
2016-06-27 13:35 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2hn26zm.fsf@russet.org.uk \
--to=phillip.lord@russet.org.uk \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).