unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Berman <stephen.berman@gmx.net>
To: emacs-devel@gnu.org
Cc: Mark Oteiza <mvoteiza@udel.edu>
Subject: master c430f7e breaks diff-mode fontification
Date: Mon, 27 Jun 2016 11:22:50 +0200	[thread overview]
Message-ID: <87k2hbasut.fsf_-_@gmx.net> (raw)
In-Reply-To: <20160623212913.536AF220129@vcs.savannah.gnu.org> (Mark Oteiza's message of "Thu, 23 Jun 2016 21:29:13 +0000 (UTC)")

This change breaks diff-mode fontification:

> branch: master
> commit c430f7e23fc2c22f251ace4254e37dea1452dfc3
> Author: Mark Oteiza <mvoteiza@udel.edu>
> Commit: Mark Oteiza <mvoteiza@udel.edu>
>
>     Remove some face aliases obsoleted in 22.1

To reproduce (after git pull and make bootstrap):

0. emacs -Q
1. C-x v L RET <path to emacs master git root> RET
2. In the *vc-change-log* buffer type `d' on one of the entries.
=> The diff displayed in the *vc-diff* buffer lack the expected faces on
   the removed and added lines, and the *Messages* buffer contains these
   messages:
Error during redisplay: (jit-lock-function 1) signaled (void-variable diff-hunk-header)
Error during redisplay: (jit-lock-function 501) signaled (void-variable diff-removed)
Error during redisplay: (jit-lock-function 1001) signaled (void-variable diff-hunk-header)
Error during redisplay: (jit-lock-function 1501) signaled (void-variable diff-context)

If prior to step 1 above I evaluate the file diff-mode.el from emacs-25
(i.e. the version before the above commit), then after 2 the *vc-diff*
buffer is fontified as expected and there no such error messages in *Messages*.

Steve Berman



       reply	other threads:[~2016-06-27  9:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160623212912.4921.57688@vcs.savannah.gnu.org>
     [not found] ` <20160623212913.536AF220129@vcs.savannah.gnu.org>
2016-06-27  9:22   ` Stephen Berman [this message]
2016-06-27 15:01     ` master c430f7e breaks diff-mode fontification Stephen Berman
2016-06-27 20:58       ` Mark Oteiza
2016-06-27 21:32         ` Stephen Berman
2016-06-28  8:25           ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2hbasut.fsf_-_@gmx.net \
    --to=stephen.berman@gmx.net \
    --cc=emacs-devel@gnu.org \
    --cc=mvoteiza@udel.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).