From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: Compilation warnings in mouse.el Date: Tue, 12 Jul 2016 10:45:59 +0200 Message-ID: <87k2gri6rc.fsf@gmx.net> References: <8360scdzik.fsf@gnu.org> <87zipnzvo4.fsf@gmx.net> <8337nfcupy.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468313184 21844 80.91.229.3 (12 Jul 2016 08:46:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jul 2016 08:46:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 12 10:46:15 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bMtKY-0003sy-EO for ged-emacs-devel@m.gmane.org; Tue, 12 Jul 2016 10:46:14 +0200 Original-Received: from localhost ([::1]:38479 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMtKX-0002Ti-IN for ged-emacs-devel@m.gmane.org; Tue, 12 Jul 2016 04:46:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMtKR-0002TS-AW for emacs-devel@gnu.org; Tue, 12 Jul 2016 04:46:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMtKL-0000Gw-Jl for emacs-devel@gnu.org; Tue, 12 Jul 2016 04:46:06 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:52454) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMtKL-0000Gj-9w; Tue, 12 Jul 2016 04:46:01 -0400 Original-Received: from rosalinde ([89.245.68.108]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MTSmp-1bn2lE3HgF-00SPkC; Tue, 12 Jul 2016 10:45:59 +0200 In-Reply-To: <8337nfcupy.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Jul 2016 08:04:57 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:XY21BJu4F/Dt9a86FeZPfbx1QxL7ZzEgEwcmadv5JnBrG6i+dWF Z4iw78sDZ58cx2DdS0vq0uOl0IoqUSQ2X84xwoeZJJk0+ilrEIhVOsa4I9DWBmYdFoad0iZ uA2YG4t2kaPVPj04W/EPa51f4GcOybHy0Jx29M6b7jQSYQsxrB3LlT8CmhSdJQB8n/lA8Uw oqCbXIti8ZRPIrfz14ydw== X-UI-Out-Filterresults: notjunk:1;V01:K0:2zBXcmVmR10=:3wqnha6ENScyvL2+AVyHH4 AoDIJUz1H0FrV42Fb26M8ezVnH0o7FfDD6Yw4IL1FRMHoJHVHSevLf9XBepN9nyRozpcCEu2M 4vEp70JqPGpTVS5ks3Ou4YVrQx/PaAEbefUWJ9yhQIfkaxoDBFJUCisI/NNjzKJWdS2xvHSzv y71R2wk1WHOWuALpArWmhzTVrkusYyqpf3Bs2pvn+7rpzvuknLqY8xGZQVnN5fXfovhuouT3L Y53NBQIwiHLQadct3a8ernHkyjNXejMFw3DnLtloYQXqdimiDsFCIOgYABbua3jKabnEevwpe OY98lwCABJTpE3TwW3cAXxPxzfO5Ap6EjHnbDL/+fnbZNPCdBN/UWgOaQ8fTFMBA9y+UO1zle lvcC+Qsxj49sb3af/fpJucz5m6uxTUdplXr8NgxEXqVN2ikKiMmjahszUEyni4nUcLtHO4MfR QXQbYcHPXQeNx/OVMbOy5q+6b5qR5Iad9lagtf5D+2nnzuUk946IES+M5DUgLEZ8kZ0NTLBcV PNOjsWlnxHFttmBRU6smhD3ADewWeQkbSO4nBpC/b3d/yf8chvaa2RP2MJAp6ns6PKYM6Qw2Y hMMzN9dGZR92v+4FQYsMThERRId8Rl6dF/OC4J1oB9sd1V3zPttcuhF5vT84fUJil/8wzdZ4o BHNAZsM4EZUs6T6RFL/mbi2HmCxEXolAwv0Km2WAXsAyv5diWrUVbOhFtTLZpD8LJt5Q4rc0Y wRp1rS3S0JT9b8MTv1W6ehDA4gnQL95lghGbp1ODK9JPvExY45js7azRmHzFbY0R78Z3Sfrt X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205571 Archived-At: On Tue, 12 Jul 2016 08:04:57 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: emacs-devel@gnu.org >> Date: Mon, 11 Jul 2016 23:55:55 +0200 >> >> > mouse.el:541:1:Warning: defcustom for `mouse-select-region-move-to-beginning' >> > fails to specify containing group >> > mouse.el:541:1:Warning: defcustom for `mouse-select-region-move-to-beginning' >> > fails to specify containing group >> >> Sorry about that. I saw that the other defcustoms in mouse.el have a >> ":group 'mouse" line and wrongly assumed this group was defined. So >> should I just add ":group 'mouse" to that defcustom or instead add a >> defgroup to mouse.el and remove the existing ":group 'mouse" lines? > > Unlike Stefan, I think we should add :group to every defcustom. > Having them mysteriously missing from some of them is a time bomb: > remove or add enough defcustoms in the same file, and you have a bug. I added the :group line in commit 2f67f8a. Steve Berman