unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Teemu Likonen <tlikonen@iki.fi>
To: emacs-devel@gnu.org
Cc: Glenn Morris <rgm@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>,
	Carsten Dominik <dominik@science.uva.nl>
Subject: org-agenda-phases-of-moon tries to call wrong function
Date: Sun, 16 Apr 2017 16:50:16 +0300	[thread overview]
Message-ID: <87k26kqx5z.fsf@iki.fi> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 386 bytes --]

(Cc'ing to hopefully right people.)

Org-agenda-mode has an "M" key for org-agenda-phases-of-moon command
which tries to call function calendar-phases-of-moon. That function
doesn't exist anymore and should be calendar-lunar-phases instead. The
bug is in the master and emacs-25 branches. The attached trivial patch
fixes the problem (and I can push it myself if someone gives an OK).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-Fix-org-agenda-s-command-for-calendar-lunar-phases.patch --]
[-- Type: text/x-diff, Size: 1053 bytes --]

From b8b3d36eb6f5a8134955170657621828c9ebbf32 Mon Sep 17 00:00:00 2001
From: Teemu Likonen <tlikonen@iki.fi>
Date: Sun, 16 Apr 2017 16:14:22 +0300
Subject: [PATCH] Fix org-agenda's command for calendar-lunar-phases

Function org-agenda-phases-of-moon tries to call a non-existing
function calendar-phases-of-moon. The correct function is
calendar-lunar-phases.
---
 lisp/org/org-agenda.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org/org-agenda.el b/lisp/org/org-agenda.el
index c870ddd..153e377 100644
--- a/lisp/org/org-agenda.el
+++ b/lisp/org/org-agenda.el
@@ -9533,7 +9533,7 @@ org-agenda-execute-calendar-command
 (defun org-agenda-phases-of-moon ()
   "Display the phases of the moon for the 3 months around the cursor date."
   (interactive)
-  (org-agenda-execute-calendar-command 'calendar-phases-of-moon))
+  (org-agenda-execute-calendar-command 'calendar-lunar-phases))
 
 (defun org-agenda-holidays ()
   "Display the holidays for the 3 months around the cursor date."
-- 
2.1.4


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

             reply	other threads:[~2017-04-16 13:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-16 13:50 Teemu Likonen [this message]
2017-04-16 18:48 ` org-agenda-phases-of-moon tries to call wrong function Paul Eggert
2017-04-17 16:55   ` Glenn Morris
2017-04-18  3:15     ` Richard Stallman
2017-04-18 16:58       ` Glenn Morris
2017-04-18 21:52         ` Richard Stallman
2017-07-03  7:22           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k26kqx5z.fsf@iki.fi \
    --to=tlikonen@iki.fi \
    --cc=dominik@science.uva.nl \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).