From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: 26.0.50; Extend dired-do-shell-command substitutions Date: Sat, 01 Jul 2017 14:06:01 +0900 Message-ID: <87k23srbk6.fsf@calancha-pc> References: <87r2y6sqsn.fsf@calancha-pc> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1498885590 24316 195.159.176.226 (1 Jul 2017 05:06:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 1 Jul 2017 05:06:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 01 07:06:24 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRAbu-000628-MB for ged-emacs-devel@m.gmane.org; Sat, 01 Jul 2017 07:06:22 +0200 Original-Received: from localhost ([::1]:46903 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRAbz-0002wY-Tz for ged-emacs-devel@m.gmane.org; Sat, 01 Jul 2017 01:06:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRAbn-0002wR-00 for emacs-devel@gnu.org; Sat, 01 Jul 2017 01:06:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRAbj-0005d9-Sb for emacs-devel@gnu.org; Sat, 01 Jul 2017 01:06:14 -0400 Original-Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:35833) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dRAbj-0005bL-MF for emacs-devel@gnu.org; Sat, 01 Jul 2017 01:06:11 -0400 Original-Received: by mail-pg0-x242.google.com with SMTP id f127so17283692pgc.2 for ; Fri, 30 Jun 2017 22:06:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=TdSrwFjzXN6ixrVSJ8WAr9iachzVKVQnNr9coKTc1g0=; b=MDoOTYXbLlZMUVAkwHORI/yCxUWbj68X3817fHMrNBjUv9uEpBoO89nT4BJ64LFF5S BbET4y+LfAp4AKu9RSuL1Ji/fvtBRZFRSaz0TPQGtp5dzi2TxlfBhhTkruWKWiGXjSjL Kb/bRF1fTA1vhG/BiJA6HriVJmV4Ub96bLnKc+J0ndBHMopP6AsvKEC5iIUspTnvJ6uP SWaMgvSlMu8MwGGJiqkLdM4QUGi3jsEg1EL7q0KvgpoDDGiRXYNcwVYTOnvOIydIP0KK hXzDSg9DUuD9dnB0UlmW6pomE6wejgiMUnDo6cPrZAUBhBcc14aeNt6f05LKLpq7eZMC jLwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TdSrwFjzXN6ixrVSJ8WAr9iachzVKVQnNr9coKTc1g0=; b=BYOW9VdByc3QDFQawGxJE1588qmXRl0fVdRrAF82RsDcsxZ0knZHIxaA0pLipR44OI Apv1YJmQrbuNCrCB1qVuunLyTeksNnaPNsSdOJJ0QldZsGtLyCC09VFNi3xwOAjkQtZ5 hiTTN+s1IYjbUmt2URu5RytI9c7aJ7YG/oBibiJHbUNNoMuEQ0LN8Nau16PiVQjrUL+2 +QzCoTm9luv/1pjpNR8ZM18BC6BaLQYYcT2mlLIUuds2mAtobE76Z+5ciM/YyMx7K9gh 0uLsGa4evEDvFoEdxOG1dDFTnZMgmcUWBOy3Nx/WxPkZVM7DlOA6rhuBTviJcCR5fShr tOtw== X-Gm-Message-State: AKS2vOy+ZJbNnGZmlX2jf1gBkslh7wl9yUkq1NIoVPWp0fJnsEfHxnvb CUvwGEJwF5sAa8f2 X-Received: by 10.99.95.216 with SMTP id t207mr25054839pgb.19.1498885567698; Fri, 30 Jun 2017 22:06:07 -0700 (PDT) Original-Received: from calancha-pc (222.139.137.133.dy.bbexcite.jp. [133.137.139.222]) by smtp.gmail.com with ESMTPSA id t26sm13603255pfl.41.2017.06.30.22.06.05 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Jun 2017 22:06:06 -0700 (PDT) In-Reply-To: <87r2y6sqsn.fsf@calancha-pc> (Tino Calancha's message of "Tue, 27 Jun 2017 00:38:00 +0900") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216072 Archived-At: Tino Calancha writes: One thing i am not sure is that in my patch i delete the two variables `dired-star-subst-regexp' and `dired-quark-subst-regexp': they are just used in dired-aux.el for the substitutions in `dired-do-shell-command': > commit cd9877d16edec71e7ea9b1eedd4194d67c1b092e > Author: Tino Calancha > Date: Tue Jun 27 00:18:45 2017 +0900 > > Extend dired-do-shell-command substitutions > > Substitute "`?`" inside command with the current file name. > * lisp/dired-aux.el (dired-quark-subst-regexp, dired-star-subst-regexp): > Delete them. > diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el > index 121bebeb65..1265fe3501 100644 > --- a/lisp/dired-aux.el > +++ b/lisp/dired-aux.el > @@ -49,8 +49,30 @@ dired-create-files-failures > ;;;###begin dired-cmd.el > ;; Diffing and compressing > > -(defconst dired-star-subst-regexp "\\(^\\|[ \t]\\)\\*\\([ \t]\\|$\\)") > -(defconst dired-quark-subst-regexp "\\(^\\|[ \t]\\)\\?\\([ \t]\\|$\\)") > +(defun dired-isolated-string-re (string) > + "Return a regexp to match STRING isolated. I am wondering if i should keep these variables in case some code out there rely on them; something like adding a comment saying that these vars are obsolete? Or is OK just to drop these vars?