unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Gemini Lasswell <gazally@runbox.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: scratch/list-threads 833a2d4 2/9: Make lisp/thread.el the new home for thread-related Lisp functions
Date: Thu, 30 Aug 2018 17:57:40 -0700	[thread overview]
Message-ID: <87k1o7wdx7.fsf@runbox.com> (raw)
In-Reply-To: <87tvndxovu.fsf@gmx.de> (Michael Albinus's message of "Wed, 29 Aug 2018 15:51:01 +0200")

Michael Albinus <michael.albinus@gmx.de> writes:

> We have now src/thread.c and lisp/emacs-lisp/thread.el. The former
> provides the feature `threads' (if Emacs is compiles with thread
> support), the latter the feature `thread'.
>
> Confusing.

Hi Michael,

Other pairs of C and Lisp files share the same name without confusion,
so the confusing bit is the feature `threads' that thread.c provides.

That made me wonder why thread.c needs to provide `threads', so I looked
at the history of that file and found that you were the one who added it
(3744fda5fa), apparently in order to be able to skip tests if Emacs is
built --without-threads.

It seems to me that (bound-and-true-p main-thread) would work as a
substitute for (featurep 'threads) in the skip-unless forms in the
thread tests.  Can you think of a reason why it wouldn't?

Gemini




  reply	other threads:[~2018-08-31  0:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180827155307.16925.11045@vcs0.savannah.gnu.org>
     [not found] ` <20180827155309.D5C18209C1@vcs0.savannah.gnu.org>
2018-08-29 13:51   ` scratch/list-threads 833a2d4 2/9: Make lisp/thread.el the new home for thread-related Lisp functions Michael Albinus
2018-08-31  0:57     ` Gemini Lasswell [this message]
2018-08-31  7:23       ` Michael Albinus
2018-08-31 13:19         ` Stefan Monnier
2018-08-31 13:41           ` Michael Albinus
2018-08-31 15:16             ` Stefan Monnier
2018-08-31 15:07           ` Eli Zaretskii
2018-09-03 13:14             ` Stefan Monnier
2018-09-03 14:15               ` Michael Albinus
2018-09-03 15:07               ` Eli Zaretskii
2018-09-03 15:17                 ` Stefan Monnier
2018-09-05 16:49             ` Gemini Lasswell
2018-09-05 17:48               ` Eli Zaretskii
2018-09-03 10:08           ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1o7wdx7.fsf@runbox.com \
    --to=gazally@runbox.com \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).