From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] open bookmark in other frame Date: Fri, 02 Nov 2018 13:55:40 -0500 Message-ID: <87k1lv5mxf.fsf@red-bean.com> References: <9d4a9ab3-d802-447e-3c74-81373b7e6101@luyten.fr> <9f2ed5a8-96c0-aa6c-b9c8-3b0f73f20aa6@luyten.fr> <357cd187-ad96-4cc6-9c01-cca87282f165@default> <8736taoo4y.fsf@red-bean.com> <6a73c984-002a-f767-6a96-3fb0822489de@luyten.fr> Reply-To: Karl Fogel NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1541184877 25480 195.159.176.226 (2 Nov 2018 18:54:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Nov 2018 18:54:37 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Pierre-Yves Luyten Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 02 19:54:33 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIeaX-0006Xe-0p for ged-emacs-devel@m.gmane.org; Fri, 02 Nov 2018 19:54:33 +0100 Original-Received: from localhost ([::1]:53090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIecd-0003di-7v for ged-emacs-devel@m.gmane.org; Fri, 02 Nov 2018 14:56:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIebx-0003dV-HP for emacs-devel@gnu.org; Fri, 02 Nov 2018 14:56:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gIebt-00012U-4O for emacs-devel@gnu.org; Fri, 02 Nov 2018 14:56:01 -0400 Original-Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]:43899) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gIebn-0000so-9t for emacs-devel@gnu.org; Fri, 02 Nov 2018 14:55:53 -0400 Original-Received: by mail-io1-xd44.google.com with SMTP id t81-v6so2073769iod.10 for ; Fri, 02 Nov 2018 11:55:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version; bh=alOrL5vJ9eVX5tvTXIFCs9r7qSLYtedEoIcGMB0eZho=; b=A67rDfPxOnxqjfBXZNcAS2rhpCeG02SMz4D+/YYToS2K80pJ1jKJTT2VLS8v5nK6pj EcHVxku3Nt+T9sWzf4xOdRIGGjGQv6y3qgJFJvUWpeC7UyBomDhK08ZyE552JelJ4lYK wXKAWTV3YGZVpJRIvN5XAGXhUITIjEJZk2/g0jtlnDp+SX28qy90UBI26vFNgg6w6PmJ RHfi5KnLnhAlq8G5NbHDJAQ//AU3+INlLKm6Lq1X64BCmvIWS/mDcEbXeh+mwT1IgQZh OhThnN2qbW/MEjRvz+/HJLq7pxR0rqVwL0TsAKXmUT6ZpBhF5QZq49cy8OnkTakJEUII utDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:reply-to :date:in-reply-to:message-id:user-agent:mime-version; bh=alOrL5vJ9eVX5tvTXIFCs9r7qSLYtedEoIcGMB0eZho=; b=ZeRFGJRRUjuHIQlLDt0Xh/ICc+G1AGl+V4Pomu1+McEUTUq8XXxceFVvBLAwBX8Jy+ VlpXdzKrxmc2L67yMZJNa4Yf1mAF9uAAYgOBTO54O9dvpgZUa4eSZOVYC4GxyvIUE/c1 zmQwDFj1oH1uf4Flt6pYGQejhPN9XW3gnH1kbxEWavmAs+kIxHmY71HybGifW8LAVLsh 7N1ygG69Y/mDADLo8uOictLJpWqSgqHlCj7ubXpaDGhAhib4PICHG7IbqcvXNVfXX9SE MZI3kIpFQTA9e8tFaoMT4QJvkoCuD8CU2voJHQ/r9/4u44E4yCL9oJl8/iOFaSyOFW4d +ptA== X-Gm-Message-State: AGRZ1gJJ+5TOmdxoMDerbbZm9DZzGe0jsXAANG4fc363/SYB5sXbLKk6 9Uq2jKBgr6nHolIGar26gHFJsXYp X-Google-Smtp-Source: AJdET5eebpU7elruOoDzynZABsH1BvjuJ4h/vrGzMw0YzEypMMKxXI26zZhUK00d8B5p4APsBl/Y5w== X-Received: by 2002:a6b:14c6:: with SMTP id 189-v6mr9542553iou.116.1541184942273; Fri, 02 Nov 2018 11:55:42 -0700 (PDT) Original-Received: from kwork (74-92-190-114-Illinois.hfc.comcastbusiness.net. [74.92.190.114]) by smtp.gmail.com with ESMTPSA id t198-v6sm4928135itf.17.2018.11.02.11.55.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Nov 2018 11:55:41 -0700 (PDT) In-Reply-To: <6a73c984-002a-f767-6a96-3fb0822489de@luyten.fr> (Pierre-Yves Luyten's message of "Sun, 14 Oct 2018 21:45:55 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d44 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230985 Archived-At: Pierre-Yves Luyten writes: >Hello, here is the change in one single patch, and a few changes to >commit message. Hi, Pierre-Yves. It's always a good idea to test changes in a freshly-built and freshly-started Emacs. In this case, because there was no ";;;###autoload" marker before `bookmark-jump-other-frame', invoking that function in a fresh Emacs would generate an error. For example, for me `bookmark-map' is bound to `C-c B', so when I did `C-c B 5' (in a new Emacs) I got an error. The fix is simple -- this change on top of your patch: --- lisp/bookmark.el +++ lisp/bookmark.el @@ -1125,6 +1125,7 @@ bookmark-jump-other-window bookmark-current-bookmark))) (bookmark-jump bookmark 'switch-to-buffer-other-window)) +;;;###autoload (defun bookmark-jump-other-frame (bookmark) "Jump to BOOKMARK in another frame. See `bookmark-jump' for more." (interactive Obviously, I could just add that ";;;###autoload" line myself commit your patch. But I thought you might want a chance to update the patch and re-post it, so that you'd have the experience of trying the change before and after. Either way is fine with me; let me know what you'd like to do. (If you're not familiar with what the autoload system does, see section 16.5 "Autoload" in the Info pages.) Best regards, -Karl