From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Keeping replace-buffer-contents runtime in bounds Date: Mon, 25 Feb 2019 07:28:17 +0100 Message-ID: <87k1hoidq6.fsf@gnu.org> References: <87r2c7ze9n.fsf@gnu.org> <83imxil8h6.fsf@gnu.org> <87y365a42g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="192086"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eli Zaretskii , Emacs developers To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 25 07:28:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gy9km-000nnw-Tv for ged-emacs-devel@m.gmane.org; Mon, 25 Feb 2019 07:28:41 +0100 Original-Received: from localhost ([127.0.0.1]:60667 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gy9kl-0002YQ-Sk for ged-emacs-devel@m.gmane.org; Mon, 25 Feb 2019 01:28:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gy9kf-0002YL-Fv for emacs-devel@gnu.org; Mon, 25 Feb 2019 01:28:34 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gy9kc-0003pr-4w; Mon, 25 Feb 2019 01:28:31 -0500 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:45483) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1gy9kS-0000nH-UL; Mon, 25 Feb 2019 01:28:24 -0500 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 5EB63220B3; Mon, 25 Feb 2019 01:28:20 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 25 Feb 2019 01:28:20 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrudehgdelfeculddtuddrgedtledrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecukfhppedufeegrdduudelrd dvgedrudelheenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomhgvshhmthhp rghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdelkedqthhsug hhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmhenucevlhhushhtvghrufhiiigv pedt X-ME-Proxy: Original-Received: from jiffyarch (j289989.servers.jiffybox.net [134.119.24.195]) by mail.messagingengine.com (Postfix) with ESMTPA id 88AEF10319; Mon, 25 Feb 2019 01:28:19 -0500 (EST) In-Reply-To: (Philipp Stephani's message of "Sun, 24 Feb 2019 21:13:03 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233592 Archived-At: Philipp Stephani writes: Hi Philipp & Eli, >> > The gotcha about aborting after more than the time-out value should >> > be mentioned in the doc string. >> > >> > Thanks for working on this. My only other comment is that maybe we >> > should allow passing the time-out value via the function's >> > arguments, not via a global variable. It seems to me the time-out >> > will be used in more use cases than MAX-COSTS, and in any case >> > treating these two differently API-wise sounds strangely >> > inconsistent. >> >> I've done that and landed it in master. > > Thanks. However, the variable replace-buffer-contents-max-secs is > still present, did you maybe keep it by mistake? Of course, yes. Feel free to delete it. Otherwise I'll do it when I'm back home this evening. And thank you both for fixing my typo in text.texi. However, now we use "@deffn Command" for replace-region-contents but it is no command. Maybe it should be one with interactive spec "a"? But how likely is it that the replacement function is already an available named function? Tassilo