* Reverting e51adfbdb7?
@ 2019-06-13 22:47 Eric Abrahamsen
2019-06-13 23:05 ` Noam Postavsky
2019-06-14 6:39 ` Stefan Monnier
0 siblings, 2 replies; 5+ messages in thread
From: Eric Abrahamsen @ 2019-06-13 22:47 UTC (permalink / raw)
To: emacs-devel; +Cc: ohwoeowho
I could have sworn I saw some discussion of this here, but now I can't
find it...
Commit e51adfbdb7 makes it impossible for me to send *any* messages via
nntp, not just those with long continuation lines. I've been running
with a local reversion for several days now. Can it either be fixed soonish,
or reverted until a fix is ready?
Thanks,
Eric
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Reverting e51adfbdb7?
2019-06-13 22:47 Reverting e51adfbdb7? Eric Abrahamsen
@ 2019-06-13 23:05 ` Noam Postavsky
2019-06-13 23:10 ` Eric Abrahamsen
2019-06-14 6:39 ` Stefan Monnier
1 sibling, 1 reply; 5+ messages in thread
From: Noam Postavsky @ 2019-06-13 23:05 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: Oleh Krehel, Emacs developers
On Thu, 13 Jun 2019 at 19:00, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
>
> I could have sworn I saw some discussion of this here, but now I can't
> find it...
This one I think? https://lists.gnu.org/r/emacs-devel/2019-06/msg00130.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Reverting e51adfbdb7?
2019-06-13 22:47 Reverting e51adfbdb7? Eric Abrahamsen
2019-06-13 23:05 ` Noam Postavsky
@ 2019-06-14 6:39 ` Stefan Monnier
2019-06-14 8:14 ` Eric Abrahamsen
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2019-06-14 6:39 UTC (permalink / raw)
To: emacs-devel
> Commit e51adfbdb7 makes it impossible for me to send *any* messages via
> nntp, not just those with long continuation lines. I've been running
> with a local reversion for several days now. Can it either be fixed soonish,
> or reverted until a fix is ready?
I'm trying the patch below right now,
Stefan
diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index 21c31f3244..86c4dce7d8 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -5178,7 +5176,7 @@ message-check-news-header-syntax
(if (= (length errors) 1) "this" "these")
(if (= (length errors) 1) "" "s")
(mapconcat 'identity errors ", ")))))))
- (message--check-continuation-headers)
+ (progn (message--check-continuation-headers) t)
;; Check the Newsgroups & Followup-To headers for syntax errors.
(message-check 'valid-newsgroups
(let ((case-fold-search t)
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: Reverting e51adfbdb7?
2019-06-14 6:39 ` Stefan Monnier
@ 2019-06-14 8:14 ` Eric Abrahamsen
0 siblings, 0 replies; 5+ messages in thread
From: Eric Abrahamsen @ 2019-06-14 8:14 UTC (permalink / raw)
To: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Commit e51adfbdb7 makes it impossible for me to send *any* messages via
>> nntp, not just those with long continuation lines. I've been running
>> with a local reversion for several days now. Can it either be fixed soonish,
>> or reverted until a fix is ready?
>
> I'm trying the patch below right now,
>
>
> Stefan
>
>
> diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
> index 21c31f3244..86c4dce7d8 100644
> --- a/lisp/gnus/message.el
> +++ b/lisp/gnus/message.el
> @@ -5178,7 +5176,7 @@ message-check-news-header-syntax
> (if (= (length errors) 1) "this" "these")
> (if (= (length errors) 1) "" "s")
> (mapconcat 'identity errors ", ")))))))
> - (message--check-continuation-headers)
> + (progn (message--check-continuation-headers) t)
> ;; Check the Newsgroups & Followup-To headers for syntax errors.
> (message-check 'valid-newsgroups
> (let ((case-fold-search t)
Well that's certainly simpler than the patch I posted to the other
thread! I was trying to keep this clause looking similar to the other
clauses, to minimize mental overhead for the reader, but whatever works...
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-14 8:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-13 22:47 Reverting e51adfbdb7? Eric Abrahamsen
2019-06-13 23:05 ` Noam Postavsky
2019-06-13 23:10 ` Eric Abrahamsen
2019-06-14 6:39 ` Stefan Monnier
2019-06-14 8:14 ` Eric Abrahamsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).