From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Slot accessing issues in EIEIO Date: Wed, 06 May 2020 10:06:25 -0700 Message-ID: <87k11pj8mm.fsf@ericabrahamsen.net> References: <87a72lhf3b.wl-all_but_last@163.com> <871rnx131x.fsf@bernoul.li> <87v9l9ypyc.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="121933"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Stefan Monnier , Zhu Zihao To: Jonas Bernoulli Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 06 19:07:03 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWNVf-000VaV-62 for ged-emacs-devel@m.gmane-mx.org; Wed, 06 May 2020 19:07:03 +0200 Original-Received: from localhost ([::1]:53544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWNVe-00074E-8T for ged-emacs-devel@m.gmane-mx.org; Wed, 06 May 2020 13:07:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38600) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWNV8-0006Qk-SA for emacs-devel@gnu.org; Wed, 06 May 2020 13:06:30 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:38190 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWNV7-0007pb-AQ for emacs-devel@gnu.org; Wed, 06 May 2020 13:06:30 -0400 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 190A1FA08E; Wed, 6 May 2020 17:06:26 +0000 (UTC) In-Reply-To: <87v9l9ypyc.fsf@bernoul.li> (Jonas Bernoulli's message of "Wed, 06 May 2020 18:43:07 +0200") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 13:06:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249102 Archived-At: Jonas Bernoulli writes: > Stefan Monnier writes: > >>>>> Recently, I'm reading the source of >>>>> closql(https://github.com/emacscollective/closql), A Emacs sqlite database ORM >>>>> package. It use eieio object, and put a piece of advice on eieio-oref to >>>>> intercept the reading slot action. >>>> >>>> Yuck! Can you explain why they need an advice on `eieio-oref`? >>> >>> A right. That's one of the reasons I never bothered to get eieio >>> changed to better accommodate my extension; I expected a negative >>> reaction like this. >> >> Note the "Yuck" is about putting an advice on such a core function. >> Not about the functionality that it provides (over which I don't have >> an opinion yet since I don't know what it does). >> >> IOW the "yuck" is saying "please request an extension so it can be >> better accomodated" ;-) > > Okay understood. I guess I was feeling a bit insecure about having > written a ORMish thing in first place, and was a bit over sensitive > because of that. ;D I would love to see this implemented, so I hope our collective insecurities do not hinder us :) I would use this, and have considered writing something similar, and am very, very glad I won't have to.