unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Karl Fogel <kfogel@red-bean.com>
To: ams@gnu.org (Alfred M. Szmidt)
Cc: michael_heerdegen@web.de, Matthias Meulien <orontee@gmail.com>,
	npostavs@gmail.com, drew.adams@oracle.com, emacs-devel@gnu.org
Subject: Re: eww and bookmarks
Date: Sun, 24 May 2020 14:06:40 -0500	[thread overview]
Message-ID: <87k1119mpr.fsf@red-bean.com> (raw)
In-Reply-To: <E1jcrO6-0006s1-P0@fencepost.gnu.org> (Alfred M. Szmidt's message of "Sun, 24 May 2020 10:14:02 -0400")

On 24 May 2020, Alfred M. Szmidt wrote:
>I haven't followed the discussion closely, so might have missed things
>-- the addition of bookmarks for URLs would be very nice.
>
>Isn't this very easily done though, both so that it works for the case
>of eww, but also (which I think is important, in the generic case),
>simple untested hackery, in .emacs.bmk we have:
>
>("The GNU Operating System and the Free Software Movement"
> (url . "http://www.gnu.org/")
> (handler . browse-url-bookmark-jump))
>
>Then browse-url-bookmark-jump is simply:
>
>(defun browse-url-bookmark-jump (bmk)
>  (let* ((url (bookmark-prop-get bmk 'url))
>         (buf (save-window-excursion (browse-url url) (current-buffer))))
>    (bookmark-default-handler
>     `("" (buffer . ,buf) . ,(bookmark-get-bookmark-record bmk)))))
>
>Those that like EWW would already be doing:
>
>  (setq browse-url-browser-function 'eww-browse-url)
>
>And then the equivalent browse-url-bookmark-make-record (e.g,
>Info-Info-bookmark-make-record) function for setting, which is left as
>a excersie for the reader -- or I can make a patch.  This might not
>work of course if you are outside of the context of Emacs.
>
>It would be strange if eww implemented its own bookmarking
>functionality, when all of this is already simple to add.

I've been watching this thread, trying to determine if any new functionality would need to be added to bookmark.el in order to support EWW bookmarks.

So far, it looks like it can all be implemented using existing functionality in bookmark.el, using `bookmark-make-record-function' and a handler function, as per above.

If it turns out that anything new is needed, please say so.  bookmark.el should be able to supply generic bookmarking functionality to other packages, and I'm happy to help with that if further extension is needed.

Best regards,
-Karl



  reply	other threads:[~2020-05-24 19:06 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 11:48 eww and bookmarks Matthias Meulien
2020-05-20 16:29 ` Drew Adams
2020-05-20 16:35   ` Noam Postavsky
2020-05-20 16:40     ` Drew Adams
2020-05-20 20:13     ` Matthias Meulien
2020-05-23 22:56       ` Michael Heerdegen
2020-05-24  8:44         ` Matthias Meulien
2020-05-24 14:14           ` Alfred M. Szmidt
2020-05-24 19:06             ` Karl Fogel [this message]
2020-05-25  4:35             ` Michael Heerdegen
2020-05-25  5:26               ` Alfred M. Szmidt
2020-05-26  2:17                 ` Michael Heerdegen
2020-06-10 15:39                   ` Lars Ingebrigtsen
2020-06-10 20:03                     ` Drew Adams
2020-05-25 12:51               ` Stefan Monnier
2020-05-25 13:52                 ` Marcin Borkowski
2020-05-25 15:03                 ` Alfred M. Szmidt
2020-05-25 15:24                   ` Stefan Monnier
2020-05-25 23:40                   ` Michael Heerdegen
     [not found]                 ` <e23432dd-212b-4bf0-8e8c-185988c653f0@default>
2020-05-26  1:04                   ` Michael Heerdegen
2020-05-27  5:10                     ` Drew Adams
2020-05-25  4:28           ` Michael Heerdegen
2020-05-25 14:35             ` T.V Raman
2020-05-20 22:14     ` Michael Heerdegen
2020-06-07 15:09       ` Michael Heerdegen
2020-06-07 15:30         ` Basil L. Contovounesios
2020-06-07 16:13           ` Michael Heerdegen
2020-06-07 16:36             ` Tomas Hlavaty
2020-06-07 18:23             ` Basil L. Contovounesios
2020-06-08 14:49               ` Michael Heerdegen
2020-06-08 16:54                 ` Basil L. Contovounesios
2020-06-10 12:01                   ` Michael Heerdegen
2020-06-07 16:36           ` Lars Ingebrigtsen
2020-06-07 18:23             ` Basil L. Contovounesios
2020-06-08 14:42           ` Michael Heerdegen
2020-06-08 16:58             ` Basil L. Contovounesios
2020-06-10 12:06               ` Michael Heerdegen
2020-10-26 18:15                 ` Adam Porter
2020-10-26 18:33                   ` Drew Adams
2020-10-26 18:43                   ` Lars Ingebrigtsen
2020-10-26 19:05                     ` Adam Porter
2020-10-26 19:26                   ` Karl Fogel
2020-06-07 16:31         ` Clément Pit-Claudel
  -- strict thread matches above, loose matches on Subject: below --
2020-05-27  7:18 Boruch Baum
2020-05-27 14:40 ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1119mpr.fsf@red-bean.com \
    --to=kfogel@red-bean.com \
    --cc=ams@gnu.org \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=npostavs@gmail.com \
    --cc=orontee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).