unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Yuan Fu <casouri@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: eldoc error in Emacs 27
Date: Mon, 27 Jul 2020 21:03:54 +0100	[thread overview]
Message-ID: <87k0yosp1x.fsf@gmail.com> (raw)
In-Reply-To: <33D61A89-7C41-4160-8C79-C756635B205C@gmail.com> (Yuan Fu's message of "Mon, 27 Jul 2020 14:51:03 -0400")

Yuan Fu <casouri@gmail.com> writes:

> 1.5. I looked around in that file and didn’t see elisp-eldoc-funcall
> defined anywhere (neither can I in the old eldoc.el that comes with
> Emacs 27).

Thanks for reporting this.  I introduced this bug.  The function you get
the error for is not defined in eldoc.el ? 1.5.0 but referenced there:

   (defun eldoc--eval-expression-setup ()
     ;; Setup `eldoc', similar to `emacs-lisp-mode'.  FIXME: Call
     ;; `emacs-lisp-mode' itself?
     (add-hook 'eldoc-documentation-functions
               #'elisp-eldoc-var-docstring nil t)
     (add-hook 'eldoc-documentation-functions
               #'elisp-eldoc-funcall nil t)
     (setq eldoc-documentation-strategy 'eldoc-documentation-default)
     (eldoc-mode +1))

Why is this Elisp-specific function in eldoc.el? Perhaps it shouldn't
be, but eldoc.el and elisp-mode.el are so unfortunately interwined so it
will have to remain there at least until we abandon Emacs 27 or make
elisp-mode.el a GNU ELPA :core package, too.

For now, the fix is to ensure that this function has an implementation
compatible with Emacs < 28, so that if you package-install a newer ElDoc
version you will not run into this problem.  The FIXME comment _could_
work in theory but I think it'll just bring more problems.  I'll post a
simpler, safer fix, soon.  In the meantime, can you make a bug report to
track this?

Thanks,
João




  reply	other threads:[~2020-07-27 20:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27 18:51 eldoc error in Emacs 27 Yuan Fu
2020-07-27 20:03 ` João Távora [this message]
2020-07-27 20:28   ` Yuan Fu
2020-07-27 20:29   ` João Távora
2020-07-27 21:13     ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0yosp1x.fsf@gmail.com \
    --to=joaotavora@gmail.com \
    --cc=casouri@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).