From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Mingde (Matthew) Zeng" Newsgroups: gmane.emacs.devel Subject: Re: [PATCHv3] erc: fix erc-reuse-buffers behavior Date: Mon, 03 Aug 2020 23:00:32 -0400 Message-ID: <87k0yfyv1r.fsf@gmail.com> References: <871rkr7pme.fsf@gmail.com> <87tuxjvk10.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9159"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.12; emacs 27.0.91 Cc: "Mingde \(Matthew\) Zeng" , Lars Ingebrigtsen , emacs-devel@gnu.org To: Amin Bandali Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 04 05:01:32 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2nCm-0002H2-Ib for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Aug 2020 05:01:32 +0200 Original-Received: from localhost ([::1]:41086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2nCl-0004iS-Fl for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Aug 2020 23:01:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2nBx-0004C6-5Q for emacs-devel@gnu.org; Mon, 03 Aug 2020 23:00:41 -0400 Original-Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]:33225) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k2nBu-0004we-Vh; Mon, 03 Aug 2020 23:00:40 -0400 Original-Received: by mail-qt1-x82b.google.com with SMTP id 6so29943121qtt.0; Mon, 03 Aug 2020 20:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=bscfWESjdZo7mPvoOf0kGs4JpJ3t8lSdShxCQBxix6k=; b=gXyMK6ajeDEI7fGg4mlVUhtuQMGvQFVGy+mTzbR8Y78QYHrtH0m2FWDcFKiuZUVFZ5 2B77kqVps3KhjOfs8hPQWPDPhGe37zRpyW9PMfrdmvbj1sCUiCrzAkElusza+TaT9qxL XjqgeoBi2yDPbUxTWauTFuj4XRMKszNu6x8KSIVAqROuX6c4EBvyWb4KNjKxB7fTdJar FivEk8GAcs6Mg9qLiPxr7h46ALAKVEs/anlZnRSBV6CtphF5FuSS6YO5Rz3bereJiPxz jf25z9xpVJYARpi+FQZGaeVD1GWrv6HK+8C847ugjqf5jxs7jfTBCeScjqcWcK7k2TRB J6tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=bscfWESjdZo7mPvoOf0kGs4JpJ3t8lSdShxCQBxix6k=; b=daxISVFNvyxFVvOatJUvPPW4zQWp384MYtHE+tLOWmZpvFNssItmGXN28zpy60PdSe IG3auM1rAa9WsAq+y0iwAAe9oZ93z5oTFrfXURS/QTlwYO4vNjf9gZNZkfv/EY0TAw3F Xyy46kEOzYasJzGbi2pVKgqWkTBID7Rg2vq7QyG+oerFQntR5o+ntWK9WUftIbCQZdyu BpXyeLyEJazzJBdc8YzKSn+QAvwi5M1ZE/E71O+ih+bnHMr+xeFqhj8Sz5M1w3MNEllj yweN1Tg8+apk1OEfymTtuwQuVLJC1yA0+P/K2zZm1BcQsQwzJ6suurqIQG4Dnr05UmwX 8mGg== X-Gm-Message-State: AOAM532cgjbr8CNbZrp4HJ1bs448hiV7nyd/iNQ7u612kzmikiJBA1Vu QpRUGDNXStgTGRqHwCNZCb1m/oQCNuU= X-Google-Smtp-Source: ABdhPJycsZx4RENVUFlirpbK/KzPT/9zl0GSuiX/zyGkecnT1Ysox/WuW/sNhKyHa9qiFU32D2ahNw== X-Received: by 2002:ac8:65c4:: with SMTP id t4mr20660626qto.264.1596510036721; Mon, 03 Aug 2020 20:00:36 -0700 (PDT) Original-Received: from mt-manjaro (216-58-109-18.cpe.distributel.net. [216.58.109.18]) by smtp.gmail.com with ESMTPSA id q4sm20523107qkm.78.2020.08.03.20.00.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2020 20:00:35 -0700 (PDT) In-reply-to: <87tuxjvk10.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::82b; envelope-from=matthewzmd@gmail.com; helo=mail-qt1-x82b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253427 Archived-At: Amin Bandali writes: > Thanks for the patch, Matthew. > > I just noticed Lars installed 6f94c2405f4c82b63da19de89549aff1fad7e594 > on master, changing erc-generate-new-buffer-name. Will your patch > require adjusting to accommodate Lars's changes? I had a look at Lars' change, that particular commit simply changes target to (not target), it is not enough to fix the problem entirely (as outlined in my commit message). Also, changing to (not target) technically does avoid this specific problem, but imo it logically doesn't make sense. When invoking `erc-generate-new-buffer-name`, target is not an optional parameter and should never be nil, that line is unnecessary amd therefore removed from my commit. Yes, I could adjust to accommodate Lars' changes, but I would remove the (not target) line, following my original logic, which is the only line Lars changed. Unless I am convinced that (not target) line is necessary to exist. I have another question, since I've never contributed to Emacs directly before, can you tell me is there any way to quickly find out whether a bug is tracked by GNU bug reports or not? > > Minor nits: > > - Please omit the "Signed-off-by:" from your commit messages to Emacs. > - Consider dropping the second "* lisp/erc/erc.el" for (erc-cmd-JOIN), > since the previous entry (erc-generate-new-buffer-name) was also a > change to lisp/erc/erc.el. Will fix them in a future patch, after the above is resolved. > > Thanks. -- Mingde (Matthew) Zeng