From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 8f28a1b: Tweak `condition-case' keyword highlights Date: Tue, 26 Jan 2021 01:25:45 +0100 Message-ID: <87k0s0mtme.fsf@gnus.org> References: <20210124203118.16450.28084@vcs0.savannah.gnu.org> <20210124203120.0ABC320AD1@vcs0.savannah.gnu.org> <87o8heovpm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1449"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 26 01:27:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l4CCL-0000FD-TT for ged-emacs-devel@m.gmane-mx.org; Tue, 26 Jan 2021 01:27:09 +0100 Original-Received: from localhost ([::1]:51164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4CCK-0003Yu-RF for ged-emacs-devel@m.gmane-mx.org; Mon, 25 Jan 2021 19:27:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4CBA-00036H-HD for emacs-devel@gnu.org; Mon, 25 Jan 2021 19:25:56 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:40960) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4CB8-0007id-TN for emacs-devel@gnu.org; Mon, 25 Jan 2021 19:25:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=37C3f0MnRoXeKgLflLD0V3AdPRE7ytuQUHXZ75Og8EM=; b=r+xNpWs+1B70uvve/2N4vAI+3x eUdqCRDiW7iZ7dZn2swWk2+W7mJnJi6soP9vr8EqQ6UNslIOHL/1Zbyf98oMcAUFzL20jJrZ+gI+i n5z4JAc3MkL7uh+Nfx/oXgpuLZJ85X5/gudmR+aFBzVW0pchFJ7rElkyccHRbEeYw6Oc=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l4CB0-00037Y-9b; Tue, 26 Jan 2021 01:25:51 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEVXSixFOiaOeD1t ZFIsJh/////yrKqJAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UBGgAMOAwuSUgAAAGiSURBVDjLbZML koMwCIbBeADYcgCbXsCtPUCY5f5nWkiiRqfp2Ix8+XlGQAIkRLguZMjvnNP2ztsFMNeNIPmPgHwd CmSkX/Z3f9DfuNkZtutSBg5PHI//Y3NsZlV8gL4slhLfgVgjDUDPw9OaLUQqg8JTQnLFO39cUn2B DSFKzot2X6BDjL+cXxqZ3YOXvGz2BWCZnqXVgiMgsWnByMuLZJDjPNljDw63rKYtP7WXCHamZT8p P+0biDqsp3UFsC1dIWBHEDGFvJyuzuhmUx4VdfcyUKys0mPswO1TN97Bmn/DhH1WFfiOtEwOCl2B sV+GaY55d19iTQE+lp85DNyDNOBjR0rSLAPwLm8vqIBtABFgnVYII30GoPXyMESMGmgHQvGNaD1c jiLroCCtguUOfJAuMG7g6AqIYq1KeL4qmDWq0lkD0Ogq+u3dq4BPoFIbp6hct1NhtIbzuYF1BGmu CpEoVk6gKRqWoF5OG4A9YqhKafGB2eDKr0DtkCYu+zwaUGpzLBJh/CPcgZQGPDU+qm8m7N2e/a6L DmBfqO7IFX7uH3vLsHede+JSAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTAxLTI2VDAwOjEyOjU1 KzAwOjAwlFhVdwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wMS0yNlQwMDoxMjo1NSswMDowMOUF 7csAAAAASUVORK5CYII= X-Now-Playing: Bobbie Gentry's _The Girl From Chickasaw County (2): The Delta Sweete_: "Sermon" In-Reply-To: (Stefan Monnier's message of "Sun, 24 Jan 2021 18:10:47 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263428 Archived-At: Stefan Monnier writes: >> (The `when' isn't a keyword here, but it's font-locked as such.) > > Yes, that one annoys me fairly often (typically with an arg named `function`). Yeah, me too. >> Couldn't we just use `edebug-form-spec' to notice that the arglist isn't >> a funcall position? > > In theory, yes. That could cover `condition-case` as well ;-) Indeed. I'm not sure how high our ambitions here are, though -- getting this right for all forms may be too slow. I was thinking we'd get 95% of the way here by just looking at the "simple" form specs. Let's see... what's the spec for `condition-case'... (symbolp form &rest ([&or symbolp (&rest symbolp)] body)) Well, OK, perhaps that's not unrealistic to apply in an efficient manner. > I think it'd be nice to use this spec for other things than just > debugging [ I remember a discussion a few .. months? .. back where > another possible use came up... oh yes, it was in the discussion about > preserving source-code location, where we could make use of this info > in order to know when the sexp is "code" which can then come with extra > annotations vs "data" in which case we need the unannotated sexp. ] Yup. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no