From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) Date: Fri, 26 Mar 2021 12:28:54 +0100 Message-ID: <87k0pu887d.fsf@gnus.org> References: <20210313133546.6042.78482@vcs0.savannah.gnu.org> <20210313133547.AA06C20B2E@vcs0.savannah.gnu.org> <877dma1yfv.fsf@tcd.ie> <87sg4ygmd9.fsf@gmx.de> <87zgz5uc0k.fsf@tcd.ie> <87tup0kxeg.fsf@tcd.ie> <878s6ba96u.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36884"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , Michael Albinus , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 26 12:31:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPkg9-0009MR-T0 for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 12:31:01 +0100 Original-Received: from localhost ([::1]:51818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPkg8-0006ch-TB for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 07:31:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPkel-0005oE-EP for emacs-devel@gnu.org; Fri, 26 Mar 2021 07:29:35 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:49524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPkeN-0006b9-Hq for emacs-devel@gnu.org; Fri, 26 Mar 2021 07:29:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tm3TFStYvj6cRY4kfVOpRYtuH6u4odJ/JwqTJ0S7G94=; b=P3/3GMM4maRGTrfnDBlDVnYtHk /NT6dr55tdsD/rZDnjcL09kl8Y4lC9wJrivrBIulOnPRI5uBSs+cJWDg81eRoMo87Ts1TZE8di5ns eyKNV0zR4yblQBGlN1EPP6N2HeJVvti994EPokjRz8VrzKnOGjp79fdTw9v9oonh3tc4=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPkeD-0000ig-Er; Fri, 26 Mar 2021 12:29:03 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEUdaMkqccyMs+NP itNAfs5untrL3fH5+/22z+ygv+b///+bnsRLAAAAAWJLR0QKaND0VgAAAAd0SU1FB+UDGgsOAGCP L9UAAAElSURBVDjLjdOxboMwEAZgG0TFCFgkc+hQdYtFq7wGKEKsTZGargQ5lzFVhzBW2fq2NW6E CXekPQmWT5zPJ37GQ7IcFv4JwW+NIHhKhRCxfsaQprGBeNyKm1Yctbo9FeMTsM5ocF9fJkDVNHiq 4ST4StFwp3Y0zJoDDfNqT293VQENZQWSAMbKz+2y30oPbnJ+TL6T8z36ImpCoV8SgZu3i3aRc3y4 CxXU/UUiCx5soKHGdTTYZQ3A17CjYKbhQMFcw56AYAUfYLc4gFKDXdYAHjpYEnDqICMO38IR4IsA gKM2DMLABoNnoMbgGOh/OQu+AYVBFIUsijVxD8Y4swn5X6K6JCLoQiuz/DmWYxChkFKinF868akz bEXDCF9P9Xap9/aqTj/A4IFV9/ORsgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0wMy0yNlQxMTox NDowMCswMDowMLezOvEAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDMtMjZUMTE6MTQ6MDArMDA6 MDDG7oJNAAAAAElFTkSuQmCC X-Now-Playing: Kraftwerk's _Autobahn_: "Kometenmelodie 2" In-Reply-To: (Stefan Monnier's message of "Thu, 25 Mar 2021 10:05:50 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267064 Archived-At: Stefan Monnier writes: >> What's the performance impact here? This is going to be called a whole >> bunch of times when the user hits TAB... > > It should be OK to do the condition-case wrapping around the loop rather > than within it, so the performance impact should be negligible. Yup; if it's hoisted out of the loop, there'd be no performance impact, but it would make it less useful, though -- as with erroring out, you'd get no completion. With it in the loop, you'd just ignore the specific predicate that fails, I think? >> I'm also not quite sure why we should be ignoring these errors -- >> they're code errors, like any others, and shouldn't be expected to >> fail, should they? > > The purpose is to make sure people can still `M-x` even in the presence > of such errors. They *should* never happen, but an error there shouldn't > render Emacs unusable ;-) I'm all for adding resiliency to central parts of Emacs, so it's good in that sense. But we don't, in general, ignore coding errors like this, I think? For instance, if there's an error when loading an .el file, we bug out -- we don't catch it and carry on. So I don't oppose catching errors here, really -- I'm just wondering why we're designing for allowing broken code in this particular circumstance. Do we expect these code snippets to break for some reason? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no