Re: Simple isearch concerns

[Juri Linkov <juri@linkov.net>]

>>> 2) I want to disable wrapping and I see that there is an
>>> `isearch-wrap-function` but it is a variable not a custom and it is not
>>> documented in detail what is expected to be there.
>>
>>isearch-wrap-function can't be a defcustom too, because it's impossible
>>to implement automatic wrapping by a wrap function.
>>
> Sorry I don't get this one, on yesterday you gave what was IMO the best
> proposal. Provide 3 options for: disable wrapping, pause and just
> wrap. Are these really so hard to provide?

Indeed, this would be nice to have.  Now the wrapping option was implemented
in bug#47599.

> * Any way if there is a reason for this; then I won't argue about that.

My point was that this required adding a completely new separate option,
not turning the existing hook into defcustom.

>>> 3) In general many of the customizable variables in isearch are defined
>>> with defvar so it is difficult to distinguish between internal and user
>>> exposed ones. Just to mention some examples:
>>> isearch-push-state-function, isearch-filter-predicate, the hooks,
>>
>>Most of these functions are intended to be modified by different modes
>>using add-function, so again there is nothing to customize here, sorry.
>>
> I use some of them as simple hooks. But again (go to *)

The existing hooks are intended to be used by modes,
and indeed they are used by modes that directly change the values
of these variable.  When the users will try to customize them,
this might have unintended consequences.