From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: vertico Date: Sat, 10 Apr 2021 19:27:23 +0200 Message-ID: <87k0paxcy4.fsf@gnu.org> References: <87im4vglwv.fsf@gnu.org> <87sg3y7g7x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9927"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.5.11; emacs 28.0.50 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 10 19:33:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVHTp-0002Vq-Hy for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 19:33:09 +0200 Original-Received: from localhost ([::1]:56752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVHTo-0006cR-Kl for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 13:33:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVHTK-0006Dw-Ma for emacs-devel@gnu.org; Sat, 10 Apr 2021 13:32:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47848) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVHTK-0005iR-Fd for emacs-devel@gnu.org; Sat, 10 Apr 2021 13:32:38 -0400 Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:40801) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1lVHTK-0004tQ-2f for emacs-devel@gnu.org; Sat, 10 Apr 2021 13:32:38 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id B5EC227C0054 for ; Sat, 10 Apr 2021 13:32:37 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 10 Apr 2021 13:32:37 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekfedgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfhgfhffvufffjgfkgggtsehttd ertddtredtnecuhfhrohhmpefvrghsshhilhhoucfjohhrnhcuoehtshguhhesghhnuhdr ohhrgheqnecuggftrfgrthhtvghrnhepveevieekteekveeigfefffeivdetgeduvdffue euudevgedttdehvdfhueevfffhnecukfhppeekjedrudeifedrfedurdduheegnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: from thinkpad-t440p (p57a31f9a.dip0.t-ipconnect.de [87.163.31.154]) by mail.messagingengine.com (Postfix) with ESMTPA id C8739240057 for ; Sat, 10 Apr 2021 13:32:36 -0400 (EDT) In-reply-to: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267831 Archived-At: Stefan Monnier writes: >>> Maybe a way to handle it "right" is for vertico to register an >>> `after-change-function` so as to detect also when the buffer's >>> content is modified outside of the normal commands (i.e. from a >>> timer or process filter). It'd probably be a bit messy, tho: it >>> wouldn't want to refresh the completion list right away, but there's >>> no "obvious" later hook to use (like `post-command-hook`) so it >>> would need to detect when there's not going to be a subsequent >>> post-command-hook (i.e. when we're in a timer or similar) and then >>> probably fire its own timer to update the completion list when the >>> current processing is done. Or maybe it should use >>> `after-change-function` to detect changes and >>> `pre-redisplay-functions` to update the list of completion. >> >> Yes, there are other hooks that could be used. I like to keep it >> simple as is and introduce nothing messy. I follow the design taken >> by Icomplete which works well. > > FWIW, I'm not convinced either that the extra complexity of what > I propose is worth the trouble. FWIW, it's absolutely no big deal for me to call `vertico--exhibit' after `minibuffer-complete' and it also doesn't seem to be costly as the former already checks if the input changed before re-computing completions. :-) Bye, Tassilo