From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Mon, 03 May 2021 19:51:18 +0300 Organization: LINKOV.NET Message-ID: <87k0ofyd4p.fsf@mail.linkov.net> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <2599ffef-4f70-025c-5f9c-61b9ac94faf8@inventati.org> <87eefrbo9k.fsf@posteo.net> <7473b27b2b479f5686af@heytings.org> <87tuon9vf1.fsf@posteo.net> <20210403174508.xwr5uc36dzityitn@Ergus> <87wnsurdr7.fsf@gmail.com> <87fszij6to.fsf@mail.linkov.net> <87v98asulc.fsf@gmail.com> <87pmyimiwd.fsf@mail.linkov.net> <87bla11u5q.fsf@gmail.com> <87lf937hgk.fsf@mail.linkov.net> <87y2d1ksga.fsf@mail.linkov.net> <87r1it7zfw.fsf@gmail.com> <87v98466it.fsf@mail.linkov.net> <87bl9wcksv.fsf@gmail.com> <87tunnzqci.fsf@mail.linkov.net> <87bl9tmzun.fsf@gmail.com> <87y2cwhiti.fsf@mail.linkov.net> <87h7jk75b7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4508"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Philip Kaludercic , Gregory Heytings , Ergus , Manuel Uberti , emacs-devel@gnu.org To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 03 19:17:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldcCH-0000zo-Hb for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 19:17:29 +0200 Original-Received: from localhost ([::1]:55002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldcCG-0005jY-IE for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 13:17:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldc02-0003qT-3y for emacs-devel@gnu.org; Mon, 03 May 2021 13:04:51 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:36679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldbzy-0008MH-Bq for emacs-devel@gnu.org; Mon, 03 May 2021 13:04:49 -0400 X-Originating-IP: 91.129.102.166 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 9EFA220008; Mon, 3 May 2021 17:04:41 +0000 (UTC) In-Reply-To: <87h7jk75b7.fsf@gmail.com> (Augusto Stoffel's message of "Mon, 03 May 2021 07:30:04 +0200") Received-SPF: pass client-ip=217.70.183.200; envelope-from=juri@linkov.net; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268824 Archived-At: >>> 3. The after change hook should call `isearch-update' instead of >>> `isearch-search-and-update' after `previous-history-element' and few >>> other commands. In isearch-mb I use a symbol property to keep track >>> of this. >> >> Thanks, it seems many solutions could be taken from isearch-mb to >> isearch.el. > > Actually, since I thought this thing through already, I would be happy > to provide a patch implementing the minibuffer-controlled isearch. It would be nice if your experience with the minibuffer-controlled isearch could help to bring the same feature to isearch.el. > May I suggest that you merge just the `isearch-buffer-local' change at > this point, and then wait for my patch doing the minibuffer part? Testing shows that the `isearch-buffer-local' change works fine, with only one deficiency: as (info "(elisp) Searching Keymaps") says get-char-property takes precedence over emulation-mode-map-alists. This means that typing isearch characters when point is e.g. on a Gnus attachment line, typing a character like 'o' bound to 'gnus-mime-save-part' will exit isearch and run this command. I see no way to workaround this limitation. > Actually, in the patch attached to > https://lists.gnu.org/archive/html/emacs-devel/2021-04/msg01359.html > (which by the way, do you think we can merge it?) Before merging I tried to check if it covers everything discussed in bug#11378.