From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Sun, 09 May 2021 22:12:59 +0300 Organization: LINKOV.NET Message-ID: <87k0o7n2kk.fsf@mail.linkov.net> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <87tuon9vf1.fsf@posteo.net> <20210403174508.xwr5uc36dzityitn@Ergus> <87wnsurdr7.fsf@gmail.com> <87fszij6to.fsf@mail.linkov.net> <87v98asulc.fsf@gmail.com> <87pmyimiwd.fsf@mail.linkov.net> <87bla11u5q.fsf@gmail.com> <87lf937hgk.fsf@mail.linkov.net> <87y2d1ksga.fsf@mail.linkov.net> <87r1it7zfw.fsf@gmail.com> <87v98466it.fsf@mail.linkov.net> <87bl9wcksv.fsf@gmail.com> <87tunnzqci.fsf@mail.linkov.net> <87bl9tmzun.fsf@gmail.com> <87y2cwhiti.fsf@mail.linkov.net> <87h7jk75b7.fsf@gmail.com> <87k0ofyd4p.fsf@mail.linkov.net> <875yzwq4x7.fsf@mail.linkov.net> <875yzumpur.fsf@mail.linkov.net> <87v97tcyx5.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17644"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Philip Kaludercic , emacs-devel@gnu.org, Manuel Uberti , Gregory Heytings , Ergus To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 09 21:18:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfown-0004Tq-3g for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 21:18:37 +0200 Original-Received: from localhost ([::1]:38880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfowm-00039a-4y for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 15:18:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfovC-0000uO-TF for emacs-devel@gnu.org; Sun, 09 May 2021 15:16:58 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:59419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfovB-0001cQ-1S for emacs-devel@gnu.org; Sun, 09 May 2021 15:16:58 -0400 X-Originating-IP: 91.129.102.166 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 87CAAE0006; Sun, 9 May 2021 19:16:52 +0000 (UTC) In-Reply-To: <87v97tcyx5.fsf@gmail.com> (Augusto Stoffel's message of "Sat, 08 May 2021 12:17:26 +0200") Received-SPF: pass client-ip=217.70.183.196; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269097 Archived-At: >>> The current design is not without flaws either: when multi-buffer >>> isearch visits another buffer, it removes the isearch menu, because >>> isearch-mode is already buffer-local. >> >> This patch fixes the problem. It disables isearch-mode in the previous >> buffer, and enables in the next buffer. > > Do you think the `with-isearch-window-quitting-edit' macro from the > patch I sent in the "Controlling Isearch from the minibuffer" thread > will be sufficient to make this work in conjunction with the > minibuffer-controlled mode? Using multi-buffer isearch with isearch-from-minibuffer adds a new dimension to complexity, but could be simplified when all isearch commands will be redirected from the minibuffer to the original buffer. The main problem is that currently quitting the minibuffer restores the original window configuration, so quitting isearch-edit-string will restore the original buffer state before isearch was started.