From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Date: Tue, 18 May 2021 01:58:37 -0500 Message-ID: <87k0nw1qaq.fsf@red-bean.com> References: <1df50c0d035675f851387d689030d588@purelymail.com> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20780"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Paul W. Rankin" To: Emacs Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 18 08:59:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lithV-0005DK-0h for ged-emacs-devel@m.gmane-mx.org; Tue, 18 May 2021 08:59:33 +0200 Original-Received: from localhost ([::1]:60144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lithT-00011O-Fy for ged-emacs-devel@m.gmane-mx.org; Tue, 18 May 2021 02:59:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1litgj-0000Id-Bz for emacs-devel@gnu.org; Tue, 18 May 2021 02:58:45 -0400 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]:51602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1litgh-0007u4-7j for emacs-devel@gnu.org; Tue, 18 May 2021 02:58:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=v/bgP79gx2ypgzeYjge7+zu57vjFuy7HuCMToh25Kdc=; t=1621321119; x=1622530719; b=hUf1IEiTAmhpTb1t3Nv31sLherIQTv1EFvjFPcfhF89ijrCk3fSwFVu1LDdcBMbRLw6EVkiXAy IxZNzVMp3QJUB9HnvyjOQzF6YxHXeDobrcgw3ZLifvpkYc/WNC3IJdHPIh91uKGhTbC+ms0K4RmEJ j+p3GdaOy0IojKi4l5i5FXBUnmyCiutrwXGsonbbcItvioWUIXXMkxQXy+3/LYSnaPHGjYpgq7CWl KQXVr/g2X0Dit2WrNRgNtJzxt2j+8OjFlBg2ixX1xcANutyz9K6CUSy20tSbcZwAEF/lxuT6M1/oI 1iU3alfuXEb5DLUqWD+1FXLXTl5lLVRrmin8w==; Original-Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net ([99.112.125.163]:35358 helo=floss) by sanpietro.red-bean.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1litgc-0007WB-4C; Tue, 18 May 2021 06:58:38 +0000 In-Reply-To: <1df50c0d035675f851387d689030d588@purelymail.com> (Paul W. Rankin's message of "Tue, 18 May 2021 16:20:29 +1000") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269433 Archived-At: On 18 May 2021, Paul W. Rankin" via "Emacs development discussions. wrote: >Ugh. Not sure how this slipped into master but it is not a >good/considerate idea to set default value of bookmark-fontify to >t. > >If there are no reasonable objections I'll push this later today. I don't have a strong opinion either way, but if you're curious as to where this came from, it was here: commit ab6cb65cb2b6d11a7b690dfcea8d98611290fad9 Author: Boruch Baum AuthorDate: Tue May 4 10:58:52 2021 +0200 Commit: Lars Ingebrigtsen CommitDate: Tue May 4 10:58:52 2021 +0200 Fontify lines when setting a bookmark * lisp/bookmark.el (bookmark-fontify): New user option (bug#48179). (bookmark-face): New face. (bookmark--fontify, bookmark--unfontify): New functions. (bookmark-set-internal, bookmark--jump-via, bookmark-delete): Use them. The discussion in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48179 is quite long, so it might be worth reading before reverting. Best regards, -Karl