From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Unicode combining characters Date: Thu, 27 May 2021 11:34:55 +0100 Message-ID: <87k0nkcvn4.fsf@tcd.ie> References: <83k0nmbubk.fsf@gnu.org> <83v975ac4s.fsf@gnu.org> <83lf81a04l.fsf@gnu.org> <83y2c08qg2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37229"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Anand Tamariya To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 27 13:11:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmDv9-0009Sm-65 for ged-emacs-devel@m.gmane-mx.org; Thu, 27 May 2021 13:11:23 +0200 Original-Received: from localhost ([::1]:36142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmDv7-0003N4-Ts for ged-emacs-devel@m.gmane-mx.org; Thu, 27 May 2021 07:11:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmDMG-0006ky-Ev for emacs-devel@gnu.org; Thu, 27 May 2021 06:35:21 -0400 Original-Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:40786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmDLx-0001hK-0f for emacs-devel@gnu.org; Thu, 27 May 2021 06:35:11 -0400 Original-Received: by mail-wr1-x42b.google.com with SMTP id z17so4208609wrq.7 for ; Thu, 27 May 2021 03:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=8VYiFUdLcY/w06dtfOFWw2vTJmYmCETSXt0fp5qt89o=; b=Fpc87nkMMAwLY+2e4G0xbFC6+ghA9v1QC0TggcDDUBpVVchYDYbKgu3wIp0xNVbOA+ ozkh3uxauWhqXnqEugNfVpW4cFc1x1tkpzefVp1oCBUixOjM7hYwnRUJf37j7Gjpmwf3 SNhiwxRQB4qDH2McevBYb/RrcDbguEbh/v8z2uBJSZBAbae3yfYeQGP6j2JcyYxrU+dM DlZ1Ny4+C/4+9qcMAqMcYPRiwJmhwHCmxivT2dCRSB6mVW3ZDi9bC5QADVT0btbzaDYT uHrLzWJBD0KmWhbymCESP265kq8PJUalMBSb0LGvm1TSkGfIhKgr5x5ACIrGxk+XZV7y BktQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=8VYiFUdLcY/w06dtfOFWw2vTJmYmCETSXt0fp5qt89o=; b=EX8K27wbIJz9FqH0OxLQ3r0erIA/JE3Hjp93p3j9Y4OUjvBjm+rXS3hirXJTKyvrtH H49ZvsJEGNO2NgmX5tmuli188w3cWih6FwBvqXtLlukr7bpuMqpuoJWO7LvR+Q9Y4MZB Ke4jb5u8ilXsTRRT9+j+pLTX1HetrPPaOoaNO1vXBIrwQ8HgNEese4Kw2JqPg9Ke35J0 ORjVK/mw0iNmOcnzqOQkCIJ/14vLMKZ+cciwZ4LZ4kWshw0w+yn+Tm6DqsTWFzza61IY Ehegc8zRGOBQW4ZW94vWEpLcOVgPRF5aymbCGb28G7o1gDQjv4SOa7231o7jZV3RnyIL q/Cw== X-Gm-Message-State: AOAM5328Z25VIHKQM3mmhnMW5L4slVwh3EqOqGEg25/9K0//dML5d841 CEuoIznoxbgTFuRnZlVrb+irYg== X-Google-Smtp-Source: ABdhPJzvuI+TgdZPQ9jypmXpBiUH5ej/CxeeGeS0pyzs5ppbw3DyQ5W/XIvInrLBLJrD6d2nxrHtcQ== X-Received: by 2002:adf:f212:: with SMTP id p18mr2524260wro.318.1622111697318; Thu, 27 May 2021 03:34:57 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id l16sm11148450wmj.47.2021.05.27.03.34.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 03:34:56 -0700 (PDT) In-Reply-To: <83y2c08qg2.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 May 2021 12:40:45 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269939 Archived-At: Eli Zaretskii writes: > OK, I improved this case now on master, please take a look I'm seeing a couple of warnings: character.c: In function =E2=80=98lisp_string_width=E2=80=99: character.c:397:16: warning: assignment to =E2=80=98int=E2=80=99 from =E2= =80=98Lisp_Object=E2=80=99 {aka =E2=80=98struct Lisp_X *=E2=80=99} makes integer from pointer withou= t a cast [-Wint-conversion] 397 | font_width =3D AREF (font_info, 11); | ^ character.c:398:19: warning: ordered comparison of pointer with integer zero [-Wextra] 398 | if (font_info <=3D 0) | ^~ character.c:399:18: warning: assignment to =E2=80=98int=E2=80=99 from =E2= =80=98Lisp_Object=E2=80=99 {aka =E2=80=98struct Lisp_X *=E2=80=99} makes integer from pointer without a c= ast [-Wint-conversion] 399 | font_width =3D AREF (font_info, 10); Do the font_info elements need to be untagged, and font_width rather than font_info checked for being positive? Thanks, --=20 Basil gcc (Debian 10.2.1-6) 10.2.1 20210110