unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, Anand Tamariya <atamariya@gmail.com>
Subject: Re: Unicode combining characters
Date: Thu, 27 May 2021 11:34:55 +0100	[thread overview]
Message-ID: <87k0nkcvn4.fsf@tcd.ie> (raw)
In-Reply-To: <83y2c08qg2.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 May 2021 12:40:45 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> OK, I improved this case now on master, please take a look

I'm seeing a couple of warnings:

character.c: In function ‘lisp_string_width’:
character.c:397:16: warning: assignment to ‘int’ from ‘Lisp_Object’
  {aka ‘struct Lisp_X *’} makes integer from pointer without a cast
  [-Wint-conversion]
  397 |     font_width = AREF (font_info, 11);
      |                ^
character.c:398:19: warning: ordered comparison of pointer with integer
  zero [-Wextra]
  398 |     if (font_info <= 0)
      |                   ^~
character.c:399:18: warning: assignment to ‘int’ from ‘Lisp_Object’ {aka
  ‘struct Lisp_X *’} makes integer from pointer without a cast
  [-Wint-conversion]
  399 |       font_width = AREF (font_info, 10);

Do the font_info elements need to be untagged, and font_width rather
than font_info checked for being positive?

Thanks,

-- 
Basil

gcc (Debian 10.2.1-6) 10.2.1 20210110



  reply	other threads:[~2021-05-27 10:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 15:56 Unicode combining characters Anand Tamariya
2021-05-25 17:22 ` Stefan Monnier
2021-05-25 17:24 ` Eli Zaretskii
2021-05-25 18:15   ` Clément Pit-Claudel
2021-05-25 18:39     ` Eli Zaretskii
2021-05-25 19:30       ` Clément Pit-Claudel
2021-05-25 19:44         ` Eli Zaretskii
2021-05-26  9:51   ` Anand Tamariya
2021-05-26 10:04     ` Joost Kremers
2021-05-26 12:54     ` Eli Zaretskii
2021-05-26 17:14       ` Eli Zaretskii
2021-05-27  7:00         ` Anand Tamariya
2021-05-27  9:40           ` Eli Zaretskii
2021-05-27 10:34             ` Basil L. Contovounesios [this message]
2021-05-27 12:30               ` Eli Zaretskii
2021-05-27 13:27             ` Anand Tamariya
2021-05-27 13:44               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0nkcvn4.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=atamariya@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).