From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/files.el: Add `file-name-set-extension` Date: Thu, 10 Jun 2021 09:46:31 +0200 Message-ID: <87k0n2uppk.fsf@gmx.de> References: <6ff4b7d7-03ac-48d1-8d49-de66431d4e5b@www.fastmail.com> <87lf82y9pv.fsf@tcd.ie> <3780a7f9-19f4-4216-baa9-ce00b3dbace9@www.fastmail.com> <6ba4668c-9b39-40e0-a155-f7e583fd33b6@www.fastmail.com> <87czteeyoc.fsf@igel.home> <9a92de1b-e313-468d-aa1f-7f969ed73688@www.fastmail.com> <87h7ipcs3j.fsf@igel.home> <392FB601-CF1D-482F-B373-B443C4131412@gmail.com> <26B660D9-AC76-4AFC-9FFD-2F5D4DCA16C1@acm.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16022"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , Philipp , emacs-devel@gnu.org To: "Colin Woodbury" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 10 09:47:18 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrFPJ-0003rQ-K1 for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Jun 2021 09:47:17 +0200 Original-Received: from localhost ([::1]:57160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrFPI-0006Y7-Lr for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Jun 2021 03:47:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrFOk-0005h1-2y for emacs-devel@gnu.org; Thu, 10 Jun 2021 03:46:42 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:59969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrFOi-0005h7-Ax for emacs-devel@gnu.org; Thu, 10 Jun 2021 03:46:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1623311192; bh=ykjQBAM+b9BGOM0KFeo6obDG1FwPFNvnxDsRk5Lyc6c=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=EQ/JdTtEm852NH1kq34dMTAvMgvb1DN4hfWGguiXyV4THUz7Zo/pUF0i8YNMdfyWo yyttLfK8pyKBDz/1R1yJGkHisnUQgbg57lu71Vf3Kl6oOWVf2zfp79rZODEK95Y4QU yvnRg8cDtIXDaYnijJWAc+zG91m0WCMQCYq04W5s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.119.150]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N2mBQ-1lCOKC2gUG-0132f9; Thu, 10 Jun 2021 09:46:32 +0200 In-Reply-To: (Colin Woodbury's message of "Wed, 09 Jun 2021 13:54:23 -0700") X-Provags-ID: V03:K1:ZwTthGkVFO29EqEOztS/Hv8+wI8UNTJRMtcCqm90y0XF7Ux1WH0 CLtQnEf5n+uyEsnqK2csSKCcQyJ4wEkDOuTU2gybEJPGrfkCUmLaJh3lFEgYgGsAfdpTmIX MbsHsuEEX8YngpAGALhucrLO7xWKyh1cOA9m+1lLIBdlsFkmts1YHeuRPtav/ehMGrt5kYY lvWOZw9j7ONQEif91awsw== X-UI-Out-Filterresults: notjunk:1;V03:K0:DAy5sj2qu+E=:lhfrOXlwozEgLz6sOB0J7p 0qxP80MwBBCVNuh1I9209jpsvGJPJac9r1gGpy2RivseuM8MQWknO/fmeqwx/Wh40jqqu8pK5 0FpYZfPntilFJglq4Bu+VyccCAzmcZF9pLJ1KJOTVgOZF25WxRDb469A+5YJPIBfNz7/beQa0 OVdP7QMEzBcRKeNzhKAFOvdYuykcGCkZjgRksm645NyvmnlZceXbHx29RCnfriCRPksCaIcKR iiMUbZCY88dDs0Rk3G/LdDzPpMoir7iDPT1t3lo287qnvWbUmcDKfvpbA/baPvAVsMoh9bRbi 6JxU2MJXWsCeEoa2kQRc5UNRnrpWCZQ4fw8gO6SSlvxqAA9fLNP4C7Cxk5Lf0F2scBDwb5kKn ka4YNMVa4/7v05l2O6e8DA1lvTk3ykNIrk6Y3uu92XDO/3AicloP3f2W9gEYUDMJdrzflzD4w 0YMSRtVXvCz2paTxtzlxqK7U8dzgsxh8I2xrjV3M283QaK87LNZcCMxSqVj08hMqnLhZX0s0Q QdgD9HFZ7f97/pY/hhA+1VqxyJcydx0McrpyD5hkC27Goa1ndPZVx2ubVmyDRX7CesV6b/bBy OxTgvY7AQ0ImL2M4QJzqb6qctoaq9aQGSsSN6ciKv5hkm0oivyf1pqdIKXAZ6rukIOsyI/V/k WRkdeRltGjRbt9rNLFqxYjeQgpZqbQlfX9IwilY6e2cA2N78hbkfomS9J/HBfoMF4WhVkn5eK AXOBbwWajEsCpmUWkxprFMwAd7rQN78c3q+mg2VHu59D4qdnDuSqiNyjdg5saY0xxRQw5STa Received-SPF: pass client-ip=212.227.17.20; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270636 Archived-At: "Colin Woodbury" writes: > Hi all, Hi Colin, > + ((equal ?/ (string-to-char (substring file -1))) (error "Filename is a directory: %s" filename)) This shall be (directory-name-p file) . You cannot assume that ?/ is always the directory separator, for example on MS Windows. Best regards, Michael.