From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language Date: Fri, 20 Aug 2021 23:43:30 +0100 Message-ID: <87k0kfenzh.fsf@tcd.ie> References: <874kbrr4cq.fsf@gnus.org> <87sfz9fx0y.fsf@gnus.org> <87bl5vhng9.fsf@tcd.ie> <87sfz7fwlv.fsf@tcd.ie> <87k0kiguif.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16690"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Glenn Morris , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 21 00:44:34 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHDFZ-00047y-Uj for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Aug 2021 00:44:34 +0200 Original-Received: from localhost ([::1]:39710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHDFX-0006sR-TM for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Aug 2021 18:44:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHDEi-0006Bd-9K for emacs-devel@gnu.org; Fri, 20 Aug 2021 18:43:40 -0400 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:40780) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mHDEd-0004cX-8s for emacs-devel@gnu.org; Fri, 20 Aug 2021 18:43:39 -0400 Original-Received: by mail-wr1-x430.google.com with SMTP id k29so16221534wrd.7 for ; Fri, 20 Aug 2021 15:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=x/BfMBryOiYclKk705XV7rSrdRvqdEjc9L2bgs3AS+0=; b=GMEHR96gw144C6l+fEz2LqP3EyLHPlCKiToGiVn4ppQjAqqv1Uu7HrZiNLcCUs+WaF /AlUJKj6Dm2y7eLZZsxuZ8p5UQdaRR+ADV3bnj/Obc8nbidetKAIx8+mF+Ey9Hjxds+P YxmGmeTcvqGP5TqP3sc7zccJAwK2aLKLn1ACvrIpB8UPjxSVevuT92xYhKL5tKpC6NXO Eh9CAPhOnSWLxdomjws8ghqAs2TDdhSDeS5wxX6gcDicSP0p20z18U5ye9uksrQNzsvJ QSxWkCs0CLj/lJ7URLY0pIv120/xmB7ccFAdO+7sjrjUmP8HznqmX5GZTCzFqljrOL+Z N+DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=x/BfMBryOiYclKk705XV7rSrdRvqdEjc9L2bgs3AS+0=; b=KjuDdcnwOfVbtVgqTM1NVG0ALJCVMd7FLMfhWfUO21PsgiyqZMp83LjiCur6TV38DY KP1io7qypa0ZsAKHykdfUHUvUQ5cBoWYezBZearygvwA51SEIH2vpMAXv3UFj+My0+8k btXQ5TFlK3NYtlQlNxDeJjNUU2HQIVuLYJq00um5k/vacK7v+5Iymat/boBDCjkCMFxr 7ar72epI22ZIeB4qBRSS9Lv05+mCouWqpp/AySJr0XLqjCfW/O2AGsYWmhZqLEnV/o34 xrLrOZp9Zlg9fNXa6RyinCkWWiaub+jkhyqolgZujBZg7yVnLPkJ3D+t8JaDPGoHC9bO 7m2w== X-Gm-Message-State: AOAM5330EEYZGZIdaACteZXUEE1b0pBXesi1j9L6VK3ZSxJJ2GGtVYK+ e/DW3lAt/O0JMXeWEzQAhFq0RQ== X-Google-Smtp-Source: ABdhPJy5Ba21CYrX6Z4e7qSeY0+GLy1pCgja2Odjiy+4i/HZ5iCyvQ7r+WmpBz2IZMBB+xDfDBGRxQ== X-Received: by 2002:adf:c785:: with SMTP id l5mr1046361wrg.360.1629499412338; Fri, 20 Aug 2021 15:43:32 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id y11sm8639666wru.0.2021.08.20.15.43.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Aug 2021 15:43:31 -0700 (PDT) In-Reply-To: (Alan Mackenzie's message of "Fri, 20 Aug 2021 21:20:49 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=contovob@tcd.ie; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272749 Archived-At: Alan Mackenzie [2021-08-20 21:20 +0000] wrote: > On Fri, Aug 20, 2021 at 10:48:04 +0000, Alan Mackenzie wrote: > >> The problem is a bug in c-point-syntax. There, there is >> (i) an invocation of c-save-buffer-state, which binds buffer-undo-list >> to t, followed by >> (ii) an invocation of c-tentative-buffer-changes, which pushes nil onto >> buffer-undo-list (simulating an undo group) giving (nil t). >> (iii) A { is typed into the buffer, giving buffer-undo-list now as >> something like ((5128 . 5129) nil t). >> At this point garbage collection occurs. This strips the tail of >> buffer-undo-list, leaving ((5128 . 5129)). >> (iv) In c-tnt-chng-cleanup, primitive-undo is repeated infinitely, >> since buffer-undo-list will never become the expected value (nil t). > >> The problem would appear to be the invalid value ((5128 . 5129) nil t) in >> buffer-undo-list. > >> I'll see what I can do about this tonight. > > I've just committed a patch to master which I think fixes the problem. Thanks! That indeed fixes the hang here. If it stops the hangs from happening on Hydra as well, then the relevant electric-tests will no longer need to be skipped there. I see only one minor issue with the patch: it introduces a use of the macro c-benign-error before its definition, which gives rise to a byte-compiler warning. I would have moved the macro's definition myself, but I see the file is organised in a particular way, so I leave that to you. Thanks, -- Basil