From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Date: Mon, 13 Sep 2021 05:43:37 -0500 Message-ID: <87k0jkvjqe.fsf@alphapapa.net> References: <1df50c0d035675f851387d689030d588@purelymail.com> <87k0nw1qaq.fsf@red-bean.com> <878s4cf74z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1787"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 13 12:44:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPjSD-0000HQ-If for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Sep 2021 12:44:49 +0200 Original-Received: from localhost ([::1]:41464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPjSB-0002gp-U7 for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Sep 2021 06:44:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPjRF-000210-1n for emacs-devel@gnu.org; Mon, 13 Sep 2021 06:43:49 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:43986) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPjRD-0000qX-E1 for emacs-devel@gnu.org; Mon, 13 Sep 2021 06:43:48 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mPjRA-0009HS-0b for emacs-devel@gnu.org; Mon, 13 Sep 2021 12:43:44 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274631 Archived-At: Stefan Kangas writes: > [That was in May.] > > Lars Ingebrigtsen writes: > >> Eli Zaretskii writes: >> >> > Please don't make this change until you hear from Lars, who examined >> > the original patch and decided to install it. It doesn't get more >> > "considerate" than that. >> >> It does seem to be an unexpectedly (to me, at least) controversial >> change, so perhaps it should be tweaked. For instance, using fringe >> markers (on frames that support that) instead of highlighting the entire >> line, or something else that isn't that stark. > > This discussion sort of fizzled out with everyone, as far as I can > tell, mostly agreeing that a fringe marker or similar might be better > for the default behaviour. On master, bookmark-fontify is still t, > and the highlighting is still done by changing the background colour. > > In general, I think we are sometimes too cautious with turning on > so-called "bells and whistles", so I'm actually in one sense happy to > see that a useful new feature is enabled by default. Yet I'm a little > surprised that this particular feature happened to pass the bar. > > I personally find that highlighting the entire line is fairly > distracting, and I'm concerned that this is not a good new default > behavior. If I'm wrong, and long-time users of bookmark.el thinks > this change is great, then that's fine of course. But just in case > I'm right, perhaps we could wait with setting the default to t until > Emacs 29? That way we have a chance to wait for the new less > intrusive fringe marker feature, which sounds harder to have many > reservations about. > > WDYT? FWIW, I'm against enabling this feature by default. In my testing with Emacs 28, it's been distracting and jarring. This is especially so for me, having written a couple of packages that use bookmark records internally and `bookmark-jump' to go to them, Burly.el and Dogears.el. When I jump to or "open" a bookmark made with Burly, the highlighted line isn't generally useful or meaningful. It could be in Dogears, but I'd rather enable the feature in that package's code or its bookmark records rather than universally. (That's another issue, and forgive me if I haven't seen it mentioned before: could this setting be controlled by a setting inside a bookmark record? That could be very useful, because it could be enabled just for ones for which highlighting the line would be meaningful.) Anyway, maybe I could let-bind `bookmark-fontify' to nil around my calls to `bookmark-jump', but it still seems like an awkward, unexpected default. I can imagine seeing many questions asking something like, "I upgraded to Emacs 28 and something in my config broke. What are these yellow lines in my buffers?" I wouldn't object as much to a fringe marker being enabled by default, although I would still wonder if it's a good default.