From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 192f935 1/3: Add 'define-keymap' and 'defvar-keymap' Date: Tue, 05 Oct 2021 08:31:24 +0200 Message-ID: <87k0is7zk3.fsf@gnus.org> References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <20211004081726.AB24621048@vcs0.savannah.gnu.org> <87k0itlyx0.fsf@gnus.org> <87fstgnbtx.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24566"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 05 08:32:55 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXe0V-00068n-Jc for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Oct 2021 08:32:55 +0200 Original-Received: from localhost ([::1]:42574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXe0U-00013X-4Y for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Oct 2021 02:32:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXdzC-0008C1-0f for emacs-devel@gnu.org; Tue, 05 Oct 2021 02:31:34 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:56220) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXdz9-0006BO-9M for emacs-devel@gnu.org; Tue, 05 Oct 2021 02:31:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rruaLeU7OIc7JLZgqTmyf0wAiXCPcxi32KAAZNynqsg=; b=Ofi1Lbi/x2FsefNYPH6UoKXu2z q7EGN+gfWWVlCEze8K8NBI9DtgyieES2VjZSWoRA0TKXlGyDqrndn1ak6v4WtrWvNILAzz7a7QI27 +TY07F5YtuI5HlCfBRulK9F50IVHTtw6Tu1lZbZ1lWIsBYQIH85njk3oJLfHathcm7Do=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXdz3-0003tx-3e; Tue, 05 Oct 2021 08:31:27 +0200 X-Now-Playing: Boris's _NO_: "Genesis" In-Reply-To: (Stefan Monnier's message of "Mon, 04 Oct 2021 12:17:47 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276297 Archived-At: By the way, when looking at how this is byte-compiled, I was surprised to find that there's a lot of byte code in what's basically just a call to a function with two parameters (that are both lists), so I had a look at what's happening. If a defvar is a single list, it's byte-compiled as a single list. So the first form results in the second in the .elc file: (defvar foo-foo (list :foo "bar" "f" #'forward-line "b" #'previous-line)) (defvar foo-foo (list :foo "bar" "f" 'forward-line "b" 'previous-line)) But if we involve more things, like this: (defvar foo-foo (list (list :foo "bar") "f" #'forward-line "b" #'previous-line)) (defvar foo-foo (byte-code "\300\301D\302\303\304\305\257^E\207" [:foo "bar" "f" forward-line "b" previous-line] 5)) The latter is longer both in the .elc file and in-memory size (if memory-report is to be believed), and presumably also takes longer to execute? We've got a whole lot of defvars in Emacs that are basically lists, so I wonder whether this is something that should be tweaked in the byte compiler? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no