unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master ae9bfaa: Simplify condition in kbd
       [not found] ` <20211016202529.E509E209AA@vcs0.savannah.gnu.org>
@ 2021-10-17  7:03   ` Andreas Schwab
  2021-10-17 10:00     ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2021-10-17  7:03 UTC (permalink / raw)
  To: emacs-devel; +Cc: Stefan Kangas

On Okt 16 2021, Stefan Kangas wrote:

> branch: master
> commit ae9bfaa891c4f3cacb118aef6e35432d5fbeb88d
> Author: Stefan Kangas <stefan@marxist.se>
> Commit: Stefan Kangas <stefan@marxist.se>
>
>     Simplify condition in kbd

That's too much simplification.

Loading /home/andreas/src/emacs/emacs/lisp/emacs-lisp/tabulated-list.el (source)...
Wrong type argument: number-or-marker-p, M-left
make[2]: *** [Makefile:858: bootstrap-emacs.pdmp] Error 255
make[2]: Leaving directory '/home/andreas/src/emacs/test/src'
make[1]: *** [Makefile:450: src] Error 2
make[1]: Leaving directory '/home/andreas/src/emacs/test'
make: *** [Makefile:1148: bootstrap] Error 2

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: master ae9bfaa: Simplify condition in kbd
  2021-10-17  7:03   ` master ae9bfaa: Simplify condition in kbd Andreas Schwab
@ 2021-10-17 10:00     ` Eli Zaretskii
  2021-10-17 11:27       ` Stefan Kangas
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2021-10-17 10:00 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: stefan, emacs-devel

> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Sun, 17 Oct 2021 09:03:18 +0200
> Cc: Stefan Kangas <stefan@marxist.se>
> 
> On Okt 16 2021, Stefan Kangas wrote:
> 
> > branch: master
> > commit ae9bfaa891c4f3cacb118aef6e35432d5fbeb88d
> > Author: Stefan Kangas <stefan@marxist.se>
> > Commit: Stefan Kangas <stefan@marxist.se>
> >
> >     Simplify condition in kbd
> 
> That's too much simplification.
> 
> Loading /home/andreas/src/emacs/emacs/lisp/emacs-lisp/tabulated-list.el (source)...
> Wrong type argument: number-or-marker-p, M-left
> make[2]: *** [Makefile:858: bootstrap-emacs.pdmp] Error 255
> make[2]: Leaving directory '/home/andreas/src/emacs/test/src'
> make[1]: *** [Makefile:450: src] Error 2
> make[1]: Leaving directory '/home/andreas/src/emacs/test'
> make: *** [Makefile:1148: bootstrap] Error 2

Indeed.  And the test suite in test/lisp/subr-tests.el now also fails.

Basically,

  (kbd "M-<left>") => error

Here's the backtrace:

  Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p M-left)
    #f(compiled-function (ch) #<bytecode 0xcfc0ba503130cc2>)(M-left)
    mapcar(#f(compiled-function (ch) #<bytecode 0xcfc0ba503130cc2>) (M-left))
    kbd("M-<left>")
    (progn (kbd "M-<left>"))
    eval((progn (kbd "M-<left>")) t)
    elisp--eval-last-sexp(t)
    eval-last-sexp(t)
    eval-print-last-sexp(nil)
    funcall-interactively(eval-print-last-sexp nil)
    call-interactively(eval-print-last-sexp nil nil)
    command-execute(eval-print-last-sexp)



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: master ae9bfaa: Simplify condition in kbd
  2021-10-17 10:00     ` Eli Zaretskii
@ 2021-10-17 11:27       ` Stefan Kangas
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Kangas @ 2021-10-17 11:27 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Andreas Schwab, Emacs developers

Ouch...

I was just getting ready to sit down and fix this, but it seems like
Lars has already fixed it.  Thanks, Lars!



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-17 11:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20211016202528.4293.79873@vcs0.savannah.gnu.org>
     [not found] ` <20211016202529.E509E209AA@vcs0.savannah.gnu.org>
2021-10-17  7:03   ` master ae9bfaa: Simplify condition in kbd Andreas Schwab
2021-10-17 10:00     ` Eli Zaretskii
2021-10-17 11:27       ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).