From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 77c3d41adc: Prevent text decorations from overwriting surrounding areas on X Date: Tue, 11 Jan 2022 08:37:11 +0800 Message-ID: <87k0f7p0p4.fsf@yahoo.com> References: <164181573002.27254.10999604516337949526@vcs2.savannah.gnu.org> <20220110115530.E4B34C0DA1D@vcs2.savannah.gnu.org> <87zgo3pzu3.fsf@yahoo.com> <8335lva3ev.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35474"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 11 01:40:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n75DW-00098D-NH for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 01:40:50 +0100 Original-Received: from localhost ([::1]:56664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n75DS-0006EP-6p for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Jan 2022 19:40:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n75AG-0005P9-H7 for emacs-devel@gnu.org; Mon, 10 Jan 2022 19:37:28 -0500 Original-Received: from sonic312-25.consmr.mail.ne1.yahoo.com ([66.163.191.206]:42759) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n75AD-00013S-Sj for emacs-devel@gnu.org; Mon, 10 Jan 2022 19:37:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1641861443; bh=aF3tF0U+EslpP2RiWALWTc5CKDvmS2dVfVYAvwofWS8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=kAF7+XgzDGNgE+b461R303WtuleI/gULi52nD1hBUD9jmbdtoP5YZ3XbTbkpi/DfNDR/aVNBVQ9YLLKF0M+P2EbHw1opY490GNpkoMu0JXjlrF1taEEBOGfIpW/7C9XBEy/y4Yzvheffv49FkRWwotEphCp5l3V9rFRvesIetlMZB9j9m0fO6brR85fq3iwlPiK/dXZjtrVk+F8fHC5TwbGjuJq0U2jqgVqbvyQF7yKL5PriKBTpxMSOKpWoUQTukA1sMgy4AuEpPgbt7kmoIVqG/qalqWXAVQj74ttWrt3nP7pwei+nwJdNYDxEBQFTvS2UjW0Z9/wksGMxQAzUAA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1641861443; bh=eYlTqTfMTe8ICXzRuMuqLgJZHwmC2MxxIe/UHu9/Xip=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=YjB1yfX2it+R42/byHg1EWd1hF8yO/oIDkPvyQATqYLiTJYGjdeC7L3lNWkI0ywJCoL0MJr78riyywVIMN1/j+X+B5vCcbC1Pc6tvCoWmE3GWIMsFm4cQpM/I7QEZ8jCYTYAPYAvnAO/V8sVzgyGIntkCpgmR/PN59j2UgIA2dEHoCI6xcmlZharYDOuKqo9XmuPj/rqcOqoqpnKGSNVc/XYaV3wUVoLqEfHIGqgWRt/N6+WN/hAY6tXUTZapXlBNRmYOFdiRqHOCe8B7aNfPKFB1J2sI7sk307oD3foFLUn4Cm65XM/7zQpltlSmFd1TyUyhwlHhjAl3/P3p9i45Q== X-YMail-OSG: .MnQ1YEVM1nlqKa4AKKnYUwd_a_RxIEFxvRObyqSLVt1jQepzy_6rYqOoVtW7ep rpRFExWg5s3UzPKCHCE9oaw6ICC2E2SZL9tPO6xm3lbNKKMg5iCdx3OpyjXJfcshX45bkIIHWRuM Uf8k_HyZtP2GfPsaKkbzH2yfSLllmGlzkPN93S3IHlBv7RcLg.mVuLoSWh15grKQHMU1KU0rqvoB 5u7vJcpylmPTBwQPmQbP2XuiVAraXOdl2y88sZONmMjjsVM1eMNtH1fKYKoKZ20Z3zFpDoUEhVST eG8NGl.sZKdTfifHxiWifOncAXvWQRLU17HW3aOZZb1w77jkoUEGib72thDdazdO3T3d0Ht11y8O _8hJ55Gd31L5jTp7rWlhAC7B9CuoElPsLa8LA37FLGoTM1UAlMZ1WV7wrGOezN3flHEO7AVmrqwd 2OuB6RMXQje6gd86AGpGfuMSitcqOEy7CeRCWr0Dnt7dNBjkdawXJ6klmfCSYrwEXfoQo_bcaWUd EebEs.WRgDGAiQOxfrYtqar3puCAcMxuTLvu3sgaBdN.zhdJzFnnAhDSHQIHJThXnz38HzGE_CmB Tvna1Iq0r3D3LIesQNAshF4zsTh9WbCsdw1fdzhVUnfQXY6u5wt2g4iljzX74sDlUKBTDBrR3emd zfCjCXUcktIIvFOZU19HR35zljbXGTf849GrhlxjuJyw_yP2ukbFWS9Kiib7b3Y7R9nd6ATWnzGC rmifvL7bHXTXJOFLE2Bco1fz3zQRxl8WHOgKxhNUsQGO_acGi9mEYiaJbDBUDONN13kK1llzu9Lh 1jAS21q73VxDmTEmjGR_vDDscx1v1aUwtiTFqYkOHt X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Tue, 11 Jan 2022 00:37:23 +0000 Original-Received: by kubenode509.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID fde557b09e4800d73d59a6610a385484; Tue, 11 Jan 2022 00:37:16 +0000 (UTC) In-Reply-To: <8335lva3ev.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 10 Jan 2022 19:47:36 +0200") X-Mailer: WebService/1.1.19551 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.206; envelope-from=luangruo@yahoo.com; helo=sonic312-25.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284559 Archived-At: Eli Zaretskii writes: > I'm not sure I understand what clipping did you have in mind. In > x_draw_underwave, for example, we have this: > > /* Find and set clipping rectangle */ > > wave_clip.x = x0; > wave_clip.y = y0; > wave_clip.width = width; > wave_clip.height = wave_height; > get_glyph_string_clip_rect (s, &string_clip); > > if (!gui_intersect_rectangles (&wave_clip, &string_clip, &final_clip)) > return; > > XSetClipRectangles (display, s->gc, 0, 0, &final_clip, 1, Unsorted); > > Isn't this the clipping? Or what am I missing? That's only done in x_draw_underwave, and nowhere else where text decorations (underlines and overlines) are drawn. >> You can test by running custom-set-faces on default, enabling an >> underline or overline, and typing in a field that is extended to the end >> of the line. > Please show some actual Lisp to try this, so we wouldn't need to guess > whether the problem doesn't exist or we failed to reproduce correctly. After loading the definition of widget-field, just do this in an empty buffer: (set-face-attribute 'default nil :underline t) (save-excursion (insert (propertize "foo\n" 'face 'widget-field))) (redisplay) (insert "a") The underline of the first line will then overwrite the right fringe.