From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Findirect_function Date: Fri, 14 Jan 2022 14:03:41 +0100 Message-ID: <87k0f21nbm.fsf@elite.giraud> References: <87tue61tz1.fsf@elite.giraud> <87fspq5wmj.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27558"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: emacs-devel To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 14 14:08:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8MJn-0006zC-9t for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 14:08:35 +0100 Original-Received: from localhost ([::1]:47546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8MJl-0003J4-96 for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 08:08:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8MF9-0000ZG-Ux for emacs-devel@gnu.org; Fri, 14 Jan 2022 08:03:49 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:43726) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8MF7-0007gI-2m for emacs-devel@gnu.org; Fri, 14 Jan 2022 08:03:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=nTkYVyGmGSV8TXzN GpZvW67fXoV2RJV8WLHofAIIVHw=; h=in-reply-to:date:references:subject: cc:to:from; d=ledu-giraud.fr; b=XLiMh0IoRBmBsRXawE4OTsc/3fDGX4dfh0mCUr j/86n5Ufx3UQ6jJgv9zIogVH3hGavmnpUAjoVltkmO0llIx0ZGAsTe8fL3rBWYx+fXBsyZ mJPGozPbGACr+hkMpOAnYRztLCbiUTryFE79+LOGUnVJ41PFDSECOFakqegwVaGUe/DXIY mfaO4rAXpgg6lQm4g200uAXJU1M8pt+55ryFzVFL3mHnSFgLrGZvWBQkQu+lYMnLg7i+Yn MSCth2M9hITd6Ub1apmKJuvhsWoG7XSv8tmwnvQp90lM5afEEqSO7VYPS1jn8e3Akq8zrV Qeh8JyeUmyheM5aIDhgbr+vw== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 040a4f2b (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 14 Jan 2022 14:03:42 +0100 (CET) In-Reply-To: <87fspq5wmj.fsf@igel.home> (Andreas Schwab's message of "Fri, 14 Jan 2022 13:29:08 +0100") Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284747 Archived-At: Andreas Schwab writes: > On Jan 14 2022, Manuel Giraud wrote: > >> diff --git a/src/data.c b/src/data.c >> index f287c38fcd..65babc49e9 100644 >> --- a/src/data.c >> +++ b/src/data.c >> @@ -2380,10 +2380,8 @@ DEFUN ("indirect-function", Findirect_function, Sindirect_function, 1, 2, 0, >> if (SYMBOLP (result) && !NILP (result) >> && (result = XSYMBOL (result)->u.s.function, SYMBOLP (result))) >> result = indirect_function (result); >> - if (!NILP (result)) >> - return result; >> >> - return Qnil; >> + return result; >> } > > Looks like a leftover from commit 60f8214e97. I see it is when Findirect_function could not signal an error anymore. While here, could we remove the 'noerror' argument? -- Manuel Giraud