From: Manuel Giraud <manuel@ledu-giraud.fr>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] Findirect_function
Date: Fri, 14 Jan 2022 14:03:41 +0100 [thread overview]
Message-ID: <87k0f21nbm.fsf@elite.giraud> (raw)
In-Reply-To: <87fspq5wmj.fsf@igel.home> (Andreas Schwab's message of "Fri, 14 Jan 2022 13:29:08 +0100")
Andreas Schwab <schwab@linux-m68k.org> writes:
> On Jan 14 2022, Manuel Giraud wrote:
>
>> diff --git a/src/data.c b/src/data.c
>> index f287c38fcd..65babc49e9 100644
>> --- a/src/data.c
>> +++ b/src/data.c
>> @@ -2380,10 +2380,8 @@ DEFUN ("indirect-function", Findirect_function, Sindirect_function, 1, 2, 0,
>> if (SYMBOLP (result) && !NILP (result)
>> && (result = XSYMBOL (result)->u.s.function, SYMBOLP (result)))
>> result = indirect_function (result);
>> - if (!NILP (result))
>> - return result;
>>
>> - return Qnil;
>> + return result;
>> }
>
> Looks like a leftover from commit 60f8214e97.
I see it is when Findirect_function could not signal an error
anymore. While here, could we remove the 'noerror' argument?
--
Manuel Giraud
next prev parent reply other threads:[~2022-01-14 13:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 10:40 [PATCH] Findirect_function Manuel Giraud
2022-01-14 12:09 ` Mattias Engdegård
2022-01-14 13:00 ` Manuel Giraud
2022-01-14 12:16 ` Eli Zaretskii
2022-01-14 12:29 ` Andreas Schwab
2022-01-14 13:03 ` Manuel Giraud [this message]
2022-01-14 16:27 ` Stefan Monnier
2022-01-14 16:48 ` Manuel Giraud
2022-01-14 17:39 ` Stefan Monnier
2022-01-17 13:32 ` Manuel Giraud
2022-01-17 18:14 ` Stefan Monnier
2022-01-17 18:16 ` Stefan Monnier
2022-01-18 0:43 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0f21nbm.fsf@elite.giraud \
--to=manuel@ledu-giraud.fr \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).