From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Request for review `image-roll.el` for Emacs core (or ELPA) Date: Tue, 19 Apr 2022 07:15:48 +0000 Message-ID: <87k0bl4k7v.fsf@posteo.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19905"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel To: dalanicolai Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 19 10:19:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngj5D-0004x4-S2 for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Apr 2022 10:19:35 +0200 Original-Received: from localhost ([::1]:33996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngj5C-0005vO-CW for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Apr 2022 04:19:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44724) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngi5b-0004bt-Lw for emacs-devel@gnu.org; Tue, 19 Apr 2022 03:15:55 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:56999) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngi5Z-0007Ro-Bx for emacs-devel@gnu.org; Tue, 19 Apr 2022 03:15:55 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A746A240109 for ; Tue, 19 Apr 2022 09:15:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1650352549; bh=v3zy5lglWDCfH9JgQLIpZgmPfnvti1r7V9Nqyya31Vc=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=nbf30M7LEQjgV+m/H4Suzt1UYVfHPt3Y8Se2NPo7crMiLikawfxJzOUWgGuiyOh6h 0GzqS/cGfmF92eBF1IiiCC2mGhKbRgjA7WujMtFYQEtlcd/LUT6SfeTEFqI6SwICCQ nC1UC9jf9akjxddXkJmUFoPRKlGue3fbfti63RNEaVeJPj4A3nHh4Wnlg9QsLwn8jl uVkJj7a8yZ2EQ3n6GZHOtdjx/Qa05u9gpzOZUJfcdRq27gc8IfzgsG6W8y/C2k0g7b 1gR8Y/zCXIghx0vsowvRxPZROjOAPGYoM5UgDzGw/TYvAdcWTPnaj/0Lk0xSZSpuQc KoFHIR4vBIiPg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4KjFT11R1sz6tmF; Tue, 19 Apr 2022 09:15:48 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: (dalanicolai@gmail.com's message of "Mon, 18 Apr 2022 23:11:43 +0200") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288655 Archived-At: dalanicolai writes: > I have written a 'scroll/image roll' package that could be considered an > extension to image-mode. > The package provides a 'displaying' mechanism for displaying > images/documents as a single 'virtual scroll'. The main feature/advantage > of the package is that it allows for the 'much requested' continuous > scrolling. Have I missed something or where can I see the source code? ELPA would ideally require a public Git repository to mirror and built the packages from. > In the package I have extracted (and improved) the 'display engine' (or > whatever to call it), from some earlier experiments of implementing > continuous scroll into doc-view and pdf-tools. > > The current package can be used for displaying documents like books, but > also for displaying a selection of images. I first thought of calling it > papyrus.el (because scroll and bookroll, would clutter too much the Emacs > namespaces), but finally I thought, as it can be used to show images on a > toll, and can be considered an extension to image-mode, it would be better > to call it image-roll.el (or maybe just roll), opinions and suggestions > about the name are very welcome. > > For testing, he package contains a `papyrus-demo` function that can simply > be called after loading the package (best after starting from emacs -Q). > Additionally, as a final step, and as an example of how the package can be > used, I have included an `image-roll-directory` function in the last > section (of 38 lines only) in the file, to provide an example of how the > package can be used to display all images within some directory on a 'roll'. > This is only a minimal example; as this does not have my priority, I did > not bother to make it 'fit/scale' the images. > > However, I have written also an extension for `pdf-tools`, that provides a > toggle function so that users can toggle between the 'single' page > displaying, or the `image-roll` displaying. That file can be found here > . > That file can simply be downloaded and loaded (after first setting the path > to image-roll.el at the top of the file, of course this requires pdf-tools > to be installed). > > I would be happy with any feedback, and info about if and how (what is > required) this could be added to Emacs core. If you think this package is > not a good candidate for core (after the required modifications), then I > would also be happy if it could be added to ELPA (although the package on > itself is not very interesting, it should get used by 'extensions' e.g. for > pdf-tools, dired, doc-view, djvu.el etc.). dalanicolai writes: > (I should really switch to Emacs for mail, the above mail probably looks > terrible on the archive, anyway...) Looks fine using Gnus, I'm guessing the archive is using the HTML part of the message. > As a short comment, on pdf-scroll.el. That file contains only a few lines > of 'new' code. The major part of that > file contains copies of 'original' pdf-tools function, but with some minor > modifications. I will add comments > behind the lines containing modifications. -- Philip Kaludercic