From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [External] : [emacs bookmark.el] Sorting by last set Date: Tue, 24 May 2022 21:25:34 -0500 Message-ID: <87k0aaz6u9.fsf@red-bean.com> References: <877d6b88pz.fsf@elite.giraud> <875ylv6j58.fsf@elite.giraud> <87o7zngcgf.fsf@gnus.org> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21539"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Manuel Giraud , Drew Adams , emacs-devel To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 25 04:26:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntgji-0005Pa-SV for ged-emacs-devel@m.gmane-mx.org; Wed, 25 May 2022 04:26:59 +0200 Original-Received: from localhost ([::1]:33900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntgjh-0005Z4-N3 for ged-emacs-devel@m.gmane-mx.org; Tue, 24 May 2022 22:26:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntgic-0004nT-3I for emacs-devel@gnu.org; Tue, 24 May 2022 22:25:50 -0400 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]:39836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntgiW-00005y-6E for emacs-devel@gnu.org; Tue, 24 May 2022 22:25:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lvZxc/cGc9ganL5GxOj7vEZdPGZJ5iWVChJRoMZ7L1E=; t=1653445542; x=1654655142; b=jwZVqO2xRLt4efAoFZ5Psw/3SvMPORkzNlDJCqFn62I2gnjtpwjGD4iLhW3wrIuW0SO/RfpzcgP xFe60z1SACcDHbKGfQCRR1ys5ZnOn2EtfkW7t3IRyt+tBXW8yTK+cybWeJGu6NiooF2FyWvQ1jjgl vz9maybbypFVGuiaPmGR4Ge+Pc+zCliR45PhjNVFmiRNm8va1kdgjzgrV1PfYyNpKUV27rOPA8XQk aTBhN7N1AIws5/FuitBbY6KBgWIWGgZU1k6cMc6E2f8G14PAi6TsgsQXrMda714AWobeWdmwRBgtS CUmXFc2bFuJfuvHcNgAjdxfwsoeZZi86chXQ==; Original-Received: from [2600:1700:5654:2110::3a] (port=42210 helo=klen) by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ntgiM-00Gx0G-Jp; Wed, 25 May 2022 02:25:34 +0000 In-Reply-To: <87o7zngcgf.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 24 May 2022 17:46:56 +0200") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290230 Archived-At: On 24 May 2022, Lars Ingebrigtsen wrote: >Manuel Giraud writes: > >> Yes I've seen this comment in bookmark.el. It seems that it >> should not >> be taken lightly. So this rules out adding a "modified date" >> field (my >> 2nd option) but maybe my first option (sorting 'bookmark-alist' >> in last >> modified order by default) is still possible. > >Extending the bookmark format (by adding more fields) is totally >possible. > >I think sorting by last set sounds like a nice feature -- patches >welcome. I agree. Extending the format to add fields like 'created-date' and/or 'last-modified' date seems fine to me, to support features like this. In fact, when I was reviewing and applying Manuel's recent changes to toggle sorting in the bookmark menu buffer, I was already thinking that this would all be easier if the bookmark itself carried its creation date. Drew, correct me if my guess is wrong, but does your objection (earlier in this thread) to extending the bookmark file format stem from the fact that long ago there was at least one -- maybe more? -- format revision that was not done in a compatible way? (I think it may have been my fault, too, but it's too long ago for me to remember clearly.) Anyway, we fixed things and nowadays the format is quite easily extensible in a backwards-compatible way. The PARAM-ALIST component of each bookmark object is just an alist with a known set key/value pairs. If we add a new pair, old versions of bookmark.el will just ignore it while new versions will make use of it. If you have some other reason for objecting to extending the format, though, please say. Best regards, -Karl