From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [External] : [emacs bookmark.el] Sorting by last set Date: Sat, 04 Jun 2022 00:33:53 -0500 Message-ID: <87k09xxa9q.fsf@red-bean.com> References: <877d6b88pz.fsf@elite.giraud> <875ylv6j58.fsf@elite.giraud> <87o7zngcgf.fsf@gnus.org> <87k0a93g4z.fsf@elite.giraud> <87y1yp1vnw.fsf@elite.giraud> <877d69lyt2.fsf@red-bean.com> <87ilpsd0hv.fsf@gnus.org> <87tu9c1c0k.fsf@elite.giraud> <87leuo12fh.fsf@elite.giraud> <87zgj38ds1.fsf@gnus.org> <875ylr15nm.fsf@elite.giraud> <8735gv6rim.fsf@gnus.org> <871qwf14ef.fsf@elite.giraud> <878rqm54kc.fsf@gnus.org> <87czfvjcbx.fsf@elite.giraud> <878rqh5z2v.fsf@gnus.org> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="759"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Manuel Giraud , Stefan Monnier , Drew Adams , emacs-devel To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 04 07:35:02 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nxMRB-000AVX-Mw for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Jun 2022 07:35:02 +0200 Original-Received: from localhost ([::1]:39264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxMRA-0007ph-CI for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Jun 2022 01:35:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxMQF-0006u7-RK for emacs-devel@gnu.org; Sat, 04 Jun 2022 01:34:04 -0400 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]:36958) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxMQD-0004GR-Mx for emacs-devel@gnu.org; Sat, 04 Jun 2022 01:34:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=a/rUD+ZztMW9NPl+0PYlUxr0ThDyNWvfppUHiZ4xWGU=; t=1654320838; x=1655530438; b=NGnue6Q6IZ431MrAa6QOaxs3FoZ7Ed01XBrPcwGkXZC61BifcqyRzxunzplkaZ7Rk8G5rJQRhQt JzrMOtB1gHBnmhIqQQES+1UsCl+IERMJcdg3hZA26gbQI9UflqH2wB2S3+6Q8HsVt7TLNeW44wo35 KxRR9RloS9zlfHWLteo41TbHJ/5QAumUU+LIjgRcURx5gZWDbs1JKSGRhf841HlhBcNMZLOhKcbDw 7shyo0P226ftar6xghICNuDPbGs46GVcf/+yTm4GTiB9SkZnQ+jOHec8wWrW3qOjkEgI28012fpCc 2l+0RwROowD9iqMWr6Oh96uU+PS0NM4GrNQQ==; Original-Received: from 23-120-121-32.lightspeed.cicril.sbcglobal.net ([23.120.121.32]:45098 helo=klen) by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nxMQ6-0078KE-Cc; Sat, 04 Jun 2022 05:33:54 +0000 In-Reply-To: <878rqh5z2v.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 31 May 2022 20:36:24 +0200") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290639 Archived-At: On 31 May 2022, Lars Ingebrigtsen wrote: >Manuel Giraud writes: > >> You were right, it feels more correct to fix the tests then to >> handle >> last-modified separately. > >Thanks; pushed to Emacs 29 (with some whitespace and naming >changes to >make it fit our conventions). Manuel, thank you, and Lars, thank you (and Drew and Stefan) for the reviews. Although I normally try to be responsive to bookmark.el threads, and to do prompt review of bookmark.ela patches, right now I'm "out" for a while (helping with some parental health issues) and thus am not able to participate very much. Thanks for making this one happen. I think it's a quite nice improvement to bookmarks. Best regards, -Karl