From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master 6a2ee981c3: Add new functions for splitting the root window Date: Thu, 15 Sep 2022 09:14:14 -0700 Message-ID: <87k064399l.fsf@melete.silentflame.com> References: <166240424802.11417.12502552895310232639@vcs2.savannah.gnu.org> <86h71kseiw.fsf@mail.linkov.net> <87illzmjew.fsf@gnus.org> <868rmvxdvj.fsf@mail.linkov.net> <87bkrq5bmb.fsf@gnus.org> <87pmg69ifi.fsf@gmail.com> <87h71i3vr3.fsf@gnus.org> <864jxfghcf.fsf@mail.linkov.net> <87sfkygokp.fsf@gnus.org> <87r10hg5u7.fsf@melete.silentflame.com> <86pmg0v6my.fsf@mail.linkov.net> <87a674beup.fsf@melete.silentflame.com> <86v8psqtj7.fsf@mail.linkov.net> <87edwfe5lg.fsf@melete.silentflame.com> <864jxbw2k7.fsf@mail.linkov.net> <87o7vidiu3.fsf@melete.silentflame.com> <86r10ev44h.fsf@mail.linkov.net> <87tu59ucdx.fsf@melete.silentflame.com> <86mtb1n4ku.fsf@mail.linkov.net> <87mtb1r1xk.fsf@melete.silentflame.com> <83bkrh1985.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7402"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: Eli Zaretskii , juri@linkov.net, larsi@gnus.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 15 18:16:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYrXd-0001hi-6z for ged-emacs-devel@m.gmane-mx.org; Thu, 15 Sep 2022 18:16:42 +0200 Original-Received: from localhost ([::1]:56784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYrXc-0005QI-84 for ged-emacs-devel@m.gmane-mx.org; Thu, 15 Sep 2022 12:16:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYrVL-0003na-LN for emacs-devel@gnu.org; Thu, 15 Sep 2022 12:14:23 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:52551) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYrVJ-0005Tf-Iy; Thu, 15 Sep 2022 12:14:19 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4DB845C013A; Thu, 15 Sep 2022 12:14:16 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 15 Sep 2022 12:14:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663258456; x=1663344856; bh=ayLmYRTwYX eo1gWjyJ+SH6JdBrBgUGjWgIxeC2fdwWE=; b=APsKxWCan9NxRbn/IFgcnENLIY YhtoI/9hOfFSc06UIO/b/NU0DY13MpozDKmHmFF47MHySh0hx65sekN9+pRj4ju3 9euvI1n0+P5UKOIOR+qPt0aHpYRKViy20ko/LRXPt6qbZtkuuOstX3Y76kt/AhdC lVshEmfbQ6pTBQ2PEC0Nx0FRBLUOL1He1/YPYnG2wHTjX2RHSu0Kolt6NLxmO7uD 2UCXEq02/yfJf5aIGsln66WTSGQOOqroVDRH+RtERb6ckioVYMbR9Rz/UOINAzAj tlYlYsPQHTSFqJoQulnPLGRajJpTm+PuwcKhm7yw05Tf3wRtH1p7Peh1eGTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663258456; x=1663344856; bh=ayLmYRTwYXeo1gWjyJ+SH6JdBrBg UGjWgIxeC2fdwWE=; b=h3JngeCvuph5YzxhAH/mmmKRcTcr6GFhAtaMJnwpX3Cz /n4qtdERm+7b9CV432RpMP1UQjVI762OlS3KtB81GymYMKIt2tSJTzvcLgEoXQnk pY7kfAwkxMKOP44PTqFlpRUi1kD9QTz7xxJyhlAdddOd3J50VgFPASh2xkoo4mKd NWgENnlEp3mX/OyJIISx1aa7u8gVil5ZkrNrR6B03LcyQbDtUwbv/MG6itgH6P9u Nk1YkrQM0ZbFOETWOMSAaFgsmQjpi3piFYQxVlSYOF3OKjBVsC9HA7/DvfIID3p1 48rAkTikedsbw2aGmLyoNOY8weRdQQZFuw/k76boOw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedukedguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeffueettdefvddtteevgfeufeejgfegudfgfedutdegfeet keehuddvfeejjeeifeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Sep 2022 12:14:16 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id DA46B7F1B24; Thu, 15 Sep 2022 09:14:14 -0700 (MST) In-Reply-To: <83bkrh1985.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 15 Sep 2022 08:45:46 +0300") Received-SPF: pass client-ip=66.111.4.28; envelope-from=spwhitton@spwhitton.name; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295429 Archived-At: Hello, On Thu 15 Sep 2022 at 08:45AM +03, Eli Zaretskii wrote: >> From: Sean Whitton >> Date: Wed, 14 Sep 2022 16:06:31 -0700 >> >> Thanks for reviewing. Others haven't chimed in on this part of the >> discussion, and I've gone ahead and pushed. > > FWIW, if you want to give people chance to chime in, you should wait > longer than you did in this case. Just 7 hours is not nearly enough. > The fact that people didn't speak up in the discussion until you post > an actual patch doesn't mean they won't want to say something about > the patch, it just means they didn't have anything they considered > useful to say in response to the previous messages. It definitely > doesn't mean no one else is interested in this discussion. > > My rule of thumb is to wait for at least a week before concluding that > no one has anything to say about a patch. Yes, this slows down the > commit rate, but IMO it makes our community sense better, and > eventually the code cleaner. I meant that no-one was chiming in on the whole subthread since Monday, despite lots of posts to other subthreads. Seven hours would obviously be too short to say "others haven't chimed in". I'll keep what you say in mind in general, anyway, thank you. -- Sean Whitton