From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master 101f3cf5b9: Add support for user edits to VC command arguments Date: Fri, 23 Sep 2022 09:15:00 -0700 Message-ID: <87k05u2hkr.fsf@melete.silentflame.com> References: <166378878197.3568.7077863090259744101@vcs2.savannah.gnu.org> <20220921193303.1B687C11D81@vcs2.savannah.gnu.org> <87v8pfbw1g.fsf@gmail.com> <87illfo0kn.fsf@melete.silentflame.com> <87o7v6bjqe.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24344"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 23 18:25:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oblUc-00063u-6v for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Sep 2022 18:25:35 +0200 Original-Received: from localhost ([::1]:45348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oblUb-0007Zy-4Z for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Sep 2022 12:25:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oblKT-0006kg-Pb for emacs-devel@gnu.org; Fri, 23 Sep 2022 12:15:05 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:58609) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oblKR-0004yQ-NQ for emacs-devel@gnu.org; Fri, 23 Sep 2022 12:15:05 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6861E5C0166; Fri, 23 Sep 2022 12:15:02 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 23 Sep 2022 12:15:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1663949702; x= 1664036102; bh=C6dC3vfy7GqncoG1VyLFFLsYH8kKY+MLtCCc6wwUfIc=; b=e Gj+gayiomTvfANr2d4uZRrTbW/liLtfxO38uOXeNtZDGFurYciY7U2z2FybQJGtF FquogtL2YSuOeo/QVTm92jirYURzaZTFOqQ8R5lpBK3RZ4huJH3RaKwvJiTdCQY2 x3omILUTFfNuaKsAxQsSxtQ9Pp0iOn2m347cDStch/kFbSb12iXHef+DZPMf51Xe 4oFeFUlEKUfSU8peWfYbsX9Dt0Yzz2enqszx2Bpf70XDFntK6se3ZtkCyYBtPwyb HRhHlyKoHr+xhYADI3DCNpPyXBDk3Uj5evF5ItI/EFGbPu4TkjzYZhGWSwDiXAT6 m8q8G6pPYN1PgGlexEP8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663949702; x= 1664036102; bh=C6dC3vfy7GqncoG1VyLFFLsYH8kKY+MLtCCc6wwUfIc=; b=j XGDQZuvqfZUmHu3jRds15VwKjUbktNpDB4yTQwuUnVsog0da/B5tFBAtndDRi+hT wqfh8EgDGZrS4fLMNvW2H2ZG7qr+wAI14sCtI2Tkbudw/fncFVblq/zIzj0NiJO7 N5DY5nfpavX7PujW1PR2Si9jLEVvV1Y6a0MPwTfrlb8IICOYc/7MjTYUnm7Mf14j zh5QwVroL9Ou0u37SiftRGwLWCOshPGFVMzqlNQLhZ6uAnMmmskg09B2+vIBE8TM QfA41gUmWltZ2HeKB00JrGCS8D6N5/U2adv7e2Ocp9GXmgXVhd+qjo4n0ol8Iv1i YLg7rSobQhMABT+59hyIg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefiedguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtgfesthhqtddttderjeenucfhrhhomhepufgv rghnucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmh gvqeenucggtffrrghtthgvrhhnpefffefhjedugedutddukeejkeeuveevvdeigefhgeel teeuhfekgeekhfeljedvudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Sep 2022 12:15:02 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id C74C97F3394; Fri, 23 Sep 2022 09:15:00 -0700 (MST) In-Reply-To: <87o7v6bjqe.fsf@gmail.com> (Robert Pluim's message of "Fri, 23 Sep 2022 10:03:37 +0200") Received-SPF: pass client-ip=66.111.4.29; envelope-from=spwhitton@spwhitton.name; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296061 Archived-At: Hello, On Fri 23 Sep 2022 at 10:03AM +02, Robert Pluim wrote: >>>>>> On Thu, 22 Sep 2022 09:06:48 -0700, Sean Whitton said: > > Sean> Hello, > Sean> On Thu 22 Sep 2022 at 11:25AM +02, Robert Pluim wrote: > > >>>>>>> On Wed, 21 Sep 2022 15:33:02 -0400 (EDT), Sean Whitton said: > >> > >> > Sean> +(defvar vc-want-edit-command-p nil > Sean> + "If non-nil, let user edit the VC shell command before runni= ng it.") > Sean> + > Sean> ;; Common command execution logic > >> > >> Is the intent that someone would setq this to t? If so it should b= e a > >> defcustom. If that=CA=BCs not the intent, but it=CA=BCs just being= used to track > >> the prefix args to the various changed commands, then I think it > >> shouldn=CA=BCt appear in the docstring. > > Sean> It's the latter, it's not meant to be setq. > > Sean> What exactly do you think shouldn't appear in the docstring? > > Any reference to `vc-want-edit-command-p', if it truly is just an > internal implementation detail. Well, I was thinking that vc-do-command is for people implementing other vc-* functions, right? They might want to bind it. --=20 Sean Whitton