From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: Call for volunteers: add tree-sitter support to major modes Date: Tue, 11 Oct 2022 09:23:41 +0200 Message-ID: <87k056esci.fsf@thornhill.no> References: <83czb1jrm3.fsf@gnu.org> <878rlo7on0.fsf@thornhill.no> <83o7uki5ol.fsf@gnu.org> <87tu4c5g9j.fsf@thornhill.no> <835ygshz6k.fsf@gnu.org> <87zge3jj0j.fsf@gnus.org> <83o7uig9dm.fsf@gnu.org> <9E2D0EEB-3910-4C58-96E7-68E7C84E5097@thornhill.no> <83k056g8ez.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21327"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, acm@muc.de, emacs-devel@gnu.org, jostein@kjonigsen.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 11 09:27:29 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oi9fl-0005Md-FN for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 09:27:29 +0200 Original-Received: from localhost ([::1]:38422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oi9fk-0007Z2-Ba for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 03:27:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oi9cB-000586-2y for emacs-devel@gnu.org; Tue, 11 Oct 2022 03:23:47 -0400 Original-Received: from out0.migadu.com ([2001:41d0:2:267::]:24348) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oi9c8-0001TR-Ha; Tue, 11 Oct 2022 03:23:46 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1665473022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=67Y4jfrJ1Av/XLgbS6zLwkB4Iz4QonOyhh24aHWt7b0=; b=WtyA+zR5KIcsSPYjzyIYkAU1yeZHi08NctVIVZgzwWVIbumNROisMDICF0hErU8JY/x7Mw 9SSVAJGzxAuIWFKZ5qCGaTtNEwy5MbWLqbiXeRipqmdjYYm5OmGAGWMN++Fbg4qskeLM3h 33dXzUkZKrfKPFAufIqj6XDR6LtQYzfaIIiSUps1FbxT/CyYYHiKyA6nWhOWNk89dAVdii mCxnDMTwOQE8uZApPe8FTcOhiGS2DplCq+ZpcSCxEXaOUk4FhaTET26uEKAm/rsc6MMvLP AlLDx4/I99qZJlvez21IWwuzeICzorpO/UDtHRUFgPSOFRjOj0EL/npeQS1R7w== In-Reply-To: <83k056g8ez.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297433 Archived-At: > > Sounds good, but I don't use these modes, so take my opinions with a > grain of salt. > >> >> But I think the in-tree tree-sitter typescript-mode will have to be >> >> called something else than the out-of-tree non-tree-sitter one, at >> >> least. >> > >> >That's desirable, yes. >> >> Sure, I can rename it to tsx-mode, because that's the parser being used. > > SGTM. > Good, I'll integrate js.el into typescript-mode.el >> Why is that desirable, though? > > It prevents user confusion and conflicts, I guess? In many cases, yes, but in the Typescript case most users will be advised to move on from that mode. I don't really think there should be an issue - that repo can be archived when we have reasonable support. Jostein and/or others should of course chime in on this. How about we let it live as typescript-mode.el for now, and I can absolutely make sure the renaming happens should we decide to do so. Theo