unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: scratch/comp-static-data c7d44a658c 1/3: comp.c: Don't emit float block variables as constants.
       [not found] ` <20221120142444.0AFA5C009EC@vcs2.savannah.gnu.org>
@ 2022-11-21  0:39   ` Po Lu
  0 siblings, 0 replies; 2+ messages in thread
From: Po Lu @ 2022-11-21  0:39 UTC (permalink / raw)
  To: emacs-devel; +Cc: Vibhav Pant

Vibhav Pant <vibhavp@gmail.com> writes:

> branch: scratch/comp-static-data
> commit c7d44a658cbaaeb7a45b88d62e08fc35c354d368
> Author: Vibhav Pant <vibhavp@gmail.com>
> Commit: Vibhav Pant <vibhavp@gmail.com>
>
>     comp.c: Don't emit float block variables as constants.
>     
>     This is currently required to work around a potential bug in libgccjit
>     where the library will not recognize constant variables storing
>     structs to have the same type as their initializer rvalue.

You did not write the name of the function you changed in this commit
message.



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: scratch/comp-static-data 39b19c9bbf 3/3: comp.c: Emit subrs as union types.
       [not found] ` <20221120142444.3C4ACC009EC@vcs2.savannah.gnu.org>
@ 2022-11-21  0:41   ` Po Lu
  0 siblings, 0 replies; 2+ messages in thread
From: Po Lu @ 2022-11-21  0:41 UTC (permalink / raw)
  To: emacs-devel; +Cc: Vibhav Pant

Vibhav Pant <vibhavp@gmail.com> writes:

> branch: scratch/comp-static-data
> commit 39b19c9bbfcc2a2456cc7258bf7bb87fb890b555
> Author: Vibhav Pant <vibhavp@gmail.com>
> Commit: Vibhav Pant <vibhavp@gmail.com>
>
>     comp.c: Emit subrs as union types.
>     
>     Instead of declaring Lisp_Subr variables as Lisp_Vector, and then
>     assigning them their respective subr values by bitcasting them as
>     their subr_type, declare variables for storing Lisp_Subrs as a union
>     type of a Lisp_Subr and a Lisp_Vector. This lets us initialize the
>     constant parts of a subr at the beginning, only requiring the `comp_u'
>     field to be set at initialization in `comp_init_objs'.

You did not write the name of the function you changed in this commit
message either.  Please pay attention to how you write commit messages,
as cleaning up ChangeLog by hand prior to releases is a chore!



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-21  0:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <166895428363.859.8553170619541806257@vcs2.savannah.gnu.org>
     [not found] ` <20221120142444.0AFA5C009EC@vcs2.savannah.gnu.org>
2022-11-21  0:39   ` scratch/comp-static-data c7d44a658c 1/3: comp.c: Don't emit float block variables as constants Po Lu
     [not found] ` <20221120142444.3C4ACC009EC@vcs2.savannah.gnu.org>
2022-11-21  0:41   ` scratch/comp-static-data 39b19c9bbf 3/3: comp.c: Emit subrs as union types Po Lu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).