From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: __attribute__ ((cleanup)) and emacs-module.c Date: Sun, 12 Mar 2023 08:42:41 +0800 Message-ID: <87jzzmdcla.fsf@yahoo.com> References: <87edq7ztks.fsf.ref@yahoo.com> <87a60qqb0c.fsf@yahoo.com> <83y1oa6k71.fsf@gnu.org> <87sfehpfcv.fsf@yahoo.com> <83a60o7mif.fsf@gnu.org> <87jzzspvcl.fsf@yahoo.com> <83ttyw65v5.fsf@gnu.org> <4B15D851-5638-48E6-A789-3017A1CBA971@yahoo.com> <8584ff7c-f83e-18b1-1300-dfa0788e4443@cs.ucla.edu> <87v8jbohk4.fsf@yahoo.com> <831qlz5pas.fsf@gnu.org> <87356en2w7.fsf@yahoo.com> <83o7p22xq4.fsf@gnu.org> <875ybal55j.fsf@yahoo.com> <83fsae2sc3.fsf@gnu.org> <87cz5ijkek.fsf_-_@yahoo.com> <87r0tyhwzp.fsf@yahoo.com> <9e84c5c6-337f-e799-f031-1c443aebd412@cs.ucla.edu> <878rg4f4py.fsf@yahoo.com> <64feb9c1-190d-8522-2a90-82f9aa305d12@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9256"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philipp Stephani , Eli Zaretskii , arsen@aarsen.me, emacs-devel@gnu.org, Daniel Colascione To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 12 01:43:41 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pb9oK-0002BD-S3 for ged-emacs-devel@m.gmane-mx.org; Sun, 12 Mar 2023 01:43:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pb9nf-0005v3-SD; Sat, 11 Mar 2023 19:42:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pb9ne-0005un-Fz for emacs-devel@gnu.org; Sat, 11 Mar 2023 19:42:58 -0500 Original-Received: from sonic316-21.consmr.mail.ne1.yahoo.com ([66.163.187.147]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pb9nc-0006xh-PI for emacs-devel@gnu.org; Sat, 11 Mar 2023 19:42:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678581773; bh=ztowln6LG2nhMfrRqyXEsOW1nHL08Jv30x3S/2Q5w+w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=hNWOVqlClI+aWcPjlZOIq3AOgMZeOW4WFdgPYUCrIexK6ys0qGgiX2mKD9Qn/5w/B8t8fBPqA+CkB7b3BrxEgg2H2Wjbl7Hlao9Wq2Q9MhC5uWNWdsxtFjwYExoy4NLy89NRPvrpcERP1qsIimIbqhSs3ENgXNqqZaRuk2BL1VLLynqV4sQr9pT2Z6wO/HxcebipFMo2OwvFCtD849OJtJY2tCI+yIVBnqyd0N4a4Q49Ef1Z6qE8sqks4pre4H5BnPwIQ5YKa58jZqK+/D6gWqH75nnIThgahJYlyKdpmG20nSxS2L+2X07SdtMvAi4adVnUkrEVPx1txnE6sboRfg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678581773; bh=cSw22ihdDqd+LkwnKNhVSAGwn28dRzwyDsTfI8069pY=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=AeY6OZHJNzVyTgbKs0Zbw6QX1dvS+XYdaDkxYLfALNiEQdn1fsx84nWCRpHiNLVfUQ0RqPTACTB9MppVwvNJWXluG1YUzEzH19pRpHPbEn51lXInHXYdpr3bx+hMvLEylNRQVnIpd6isbdoORUKYonBIldbAj7JOZHyof0xpK8y8ucWPHwqeYOvArWY3ZXSJPMfnWb56l0dzmkuxuvLmckwfDmmteFrw7DilDhwJCRp1JYYJA3ckKYYDDecuBDpL3WJdloVs/k/LJwESPdtvXroeSR/ffpSHFWXaDHJN1wX1hJ0SVqOViyjAkF5+NXjGHWddbOUHknCpQovMaeFDSQ== X-YMail-OSG: Cb2XHp0VM1kd8U7hypwQww5FRADLeDx7p8oeEtKLMJ7nVH1YNf1vT8KYFXNdXRL 7QLU_3nhEw18Rbq1uyo.1UTpZvagzguoapeWOniFkN0U9o2LtRB8oL.il.HYjnBOXreFTiY5uzZt ZPC5J.XT0Xxxc0iITksddaHdRToM3vqqD2i4r9NYROfk.xErSTad6ilDbtwHqFOFBSw93EiKS5i7 noZsS3CLL2f4vBU118L0oRn0PCI3tHHthVczx63ogSG7ekkFa4jK74Pwd.pshjSG4KmxMmapptl8 dUMr891LYhwGNLqU59vaRdxwuiZaxvXECgbzwJB..Y.Jhtx6Wmde.BgOdT.k6p9kkJKONfz3zM4z EEKlhmkoWuQc2uPi60NRgbKjOqh6SuQ0.yTFwTVCG8fN.RqbNGJ4MND2XCLvISZlvKTNAO5WQ9Dz ApZeOJICkWiJDbHmNidsBJgLTifsEA8BPmmUZ2WBUQ4CgNCrbQUuw3UiPbbAGyuiIh6yij5szuQQ QLmHOHUEV5y.0DflLM2vhS79_JDKJZTMMVI1HMPdI98Ubr498_65pSWJiPJqQMfjU74o4Vkn_mXT DTzHY9I64ppKbGH8oebVjIPbUoChZqX3LKRfLvrpZlp0XsE5nHnsmFq8SlK.IJTccbWr7n5si7_K QSCHThnbOkARZ6iY5XKfn7ymTzyJ7er2D27gf4.obQLtthWH.nFOEiQ.mP5YK2kfxmfvev.wA.A_ wJKr6G2OUt.MzOa3ufnD2uhe6VvaijNLz.P.bBAGMJz2s3dc1cjvmnqQNbdElwh5ApSlQN3T2.hb 4MCmT_Y8b1iT6ZLNpzUDh8HJzkzz6EyuYTKTjeohxg X-Sonic-MF: X-Sonic-ID: 458d545d-4a4f-4b82-8349-926031b30e8a Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Sun, 12 Mar 2023 00:42:53 +0000 Original-Received: by hermes--production-sg3-67c57bccff-62k8m (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID eeadb04308eb5d09e65b1aa754d2569f; Sun, 12 Mar 2023 00:42:46 +0000 (UTC) In-Reply-To: <64feb9c1-190d-8522-2a90-82f9aa305d12@cs.ucla.edu> (Paul Eggert's message of "Sat, 11 Mar 2023 13:21:16 -0800") X-Mailer: WebService/1.1.21284 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.187.147; envelope-from=luangruo@yahoo.com; helo=sonic316-21.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304342 Archived-At: Paul Eggert writes: > On 2023-03-10 17:37, Po Lu wrote: > >> +#define MODULE_INTERNAL_CLEANUP \ >> + module_reset_handlerlist (&internal_cleanup) > > No need for the "&" here. Omit it, and change the type of > module_reset_handlerlist to take 'struct handler *' instead of 'struct > handler **'. > > Also, please make this macro a parameterless function-style macro > called via 'MODULE_INTERNAL_CLEANUP ()' as it acts like a function. OK, will do. > Also, please define a macro MODULE_FUNCTION_END something like this: > > #define MODULE_FUNCTION_END(retval) \ > (MODULE_INTERNAL_CLEANUP (), retval) > > and use 'return MODULE_FUNCTION_END ();' when the > cleanup is immediately followed by a return of a value of a simple > expression. For complex expressions that can throw exceptions, you can > use something like: > > r = ; > return MODULE_FUNCTION_END (r); I think this is likely to be confusing, because people won't realize the situations in which it cannot be used, and we will end up with code like: return MODULE_FUNCTION_END (Fthis_thing_that_calls_xmalloc ())