NonGNU ELPA: add Logview

NonGNU ELPA: add Logview

[Paul Pogonyshev]

[-- Attachment #1.1: Type: text/plain, Size: 965 bytes --]

Hi,

Bozhidar Batsov, author and maintainer of CIDER, requested for package
Logview to be made available on NonGNU ELPA:
https://github.com/clojure-emacs/cider/issues/3365

Since Logview has two dependencies itself, which are not available on
NonGNU ELPA, and since Bozhidar assured me that it is fine to submit
multiple packages in one go, the attached patch adds all three (Logview,
datetime, extmap) at once. Local checks suggest that the packages can be
built fine.

All the packages have been available from MELPA for years and are mature
projects. They are under active maintenance: even if I don't often add new
features, I respond to reported issues on GitHub and write fixes when
needed.

I added directory `githooks' to the lists of exclusions even if it doesn't
yet exist in the dependencies: I will add it there sooner or later anyway.
In Logview itself this directory already exists.

Please CC me on any replies, I'm not subscribed to the list.

Paul

[-- Attachment #1.2: Type: text/html, Size: 1217 bytes --]

[-- Attachment #2: 0001-Add-Logview-with-dependencies.patch --]
[-- Type: text/x-patch, Size: 1542 bytes --]

From 2edfe9ef6b1484e9417c140612ce60ebba789d6d Mon Sep 17 00:00:00 2001
From: Paul Pogonyshev <pogonyshev@gmail.com>
Date: Thu, 6 Jul 2023 18:00:04 +0200
Subject: [PATCH] Add Logview with dependencies.

---
 elpa-packages | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index 06107249ef..5443a44e2e 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -108,6 +108,9 @@
   :ignored-files ("LICENSE" "test" "Cask" "Makefile")
   :news "CHANGELOG.md")
 
+ (datetime		:url "https://github.com/doublep/datetime.git"
+  :ignored-files (".github" "githooks" "dev" "test" "Eldev" "LICENSE"))
+
  (denote-refs           :url "https://codeberg.org/akib/emacs-denote-refs")
 
  (devhelp               :url "https://codeberg.org/akib/emacs-devhelp")
@@ -206,6 +209,9 @@
  (evil-visualstar	:url "https://github.com/bling/evil-visualstar.git"
   :readme ("README.md"))
 
+ (extmap		:url "https://github.com/doublep/extmap.git"
+  :ignored-files (".github" "githooks" "test" "Eldev" "LICENSE"))
+
  (flx			:url "https://github.com/lewang/flx"
   :readme "README.md"
   :ignored-files (".travis.yml" "LICENSE"
@@ -384,6 +390,9 @@
  (kotlin-mode		:url "https://github.com/Emacs-Kotlin-Mode-Maintainers/kotlin-mode"
   :ignored-files ("doc" "test" "Cask" "Makefile"))
 
+ (logview		:url "https://github.com/doublep/logview.git"
+  :ignored-files (".github" "githooks" "test" "Eldev" "LICENSE" "TODO.md"))
+
  (lorem-ipsum           :url "https://github.com/jschaf/emacs-lorem-ipsum"
   :readme "README.md")
 
-- 
2.35.1

Re: NonGNU ELPA: add Logview

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

Thanks for putting the patch together so quickly!

Phillip, can you help us to get it applied? 

On Thu, Jul 6, 2023, at 7:14 PM, Paul Pogonyshev wrote:
> Hi,
> 
> Bozhidar Batsov, author and maintainer of CIDER, requested for package Logview to be made available on NonGNU ELPA: https://github.com/clojure-emacs/cider/issues/3365
> 
> Since Logview has two dependencies itself, which are not available on NonGNU ELPA, and since Bozhidar assured me that it is fine to submit multiple packages in one go, the attached patch adds all three (Logview, datetime, extmap) at once. Local checks suggest that the packages can be built fine.
> 
> All the packages have been available from MELPA for years and are mature projects. They are under active maintenance: even if I don't often add new features, I respond to reported issues on GitHub and write fixes when needed.
> 
> I added directory `githooks' to the lists of exclusions even if it doesn't yet exist in the dependencies: I will add it there sooner or later anyway. In Logview itself this directory already exists.
> 
> Please CC me on any replies, I'm not subscribed to the list.
> 
> Paul
> 
> *Attachments:*
>  • 0001-Add-Logview-with-dependencies.patch

[-- Attachment #2: Type: text/html, Size: 1777 bytes --]

Re: NonGNU ELPA: add Logview

[Philip Kaludercic]

"Bozhidar Batsov" <bozhidar@batsov.dev> writes:

> Thanks for putting the patch together so quickly!
>
> Phillip, can you help us to get it applied? 

Applying the patch is not the issue, I am just personally hesitant to
add a bunch of dependencies/packages I have never heard about before,
more so because I don't use CIDER, /especially/ when I lack the time to
properly review them (the argument that a package is "mature on MELPA"
is rather weak from my experience, especially given the number of low
quality packages on the archive).

Without understanding the issue properly, why is there a need for an
external data-time parsing package, if Emacs already comes with
functions for parsing timestamps?  It appears to use use this extmap
package, which parses binary data?  How is this all related to CIDER?

But perhaps I am in a minority here, and we should just apply the patch.

> On Thu, Jul 6, 2023, at 7:14 PM, Paul Pogonyshev wrote:
>> Hi,
>> 
>> Bozhidar Batsov, author and maintainer of CIDER, requested for
>> package Logview to be made available on NonGNU ELPA:
>> https://github.com/clojure-emacs/cider/issues/3365
>> 
>> Since Logview has two dependencies itself, which are not available
>> on NonGNU ELPA, and since Bozhidar assured me that it is fine to
>> submit multiple packages in one go, the attached patch adds all
>> three (Logview, datetime, extmap) at once. Local checks suggest that
>> the packages can be built fine.

I am a bit confused, why should adding multiple related packages in a
single patch be an issue?

>> All the packages have been available from MELPA for years and are
>> mature projects. They are under active maintenance: even if I don't
>> often add new features, I respond to reported issues on GitHub and
>> write fixes when needed.
>> 
>> I added directory `githooks' to the lists of exclusions even if it
>> doesn't yet exist in the dependencies: I will add it there sooner or
>> later anyway. In Logview itself this directory already exists.

If possible, please add ".elpaignore" files to the repositories
themselves, so that we can void tracking the files in elpa-packages
itself.

>> Please CC me on any replies, I'm not subscribed to the list.

That is a given, don't worry about it.

>> Paul
>> 
>> *Attachments:*
>>  • 0001-Add-Logview-with-dependencies.patch

Re: NonGNU ELPA: add Logview

[Paul Pogonyshev]

[-- Attachment #1: Type: text/plain, Size: 4016 bytes --]

> Without understanding the issue properly, why is there a need for an
external data-time parsing package, if Emacs already comes with functions
for parsing timestamps?

For speed. Logview is aimed at very large logs (megabytes) and also for
lazily filtering them on-the-fly, adding/removing filters and so on.
Built-in functions were not fast enough, so I had to create datetime. Also
for matching: there is no standard timestamp format, the library helps me
at building regexs needed to match timestamps in given format and also
trying to guess which of many possible formats to use for a particular file.

I didn't create the library just for fun, I saw a need for it.

> It appears to use use this extmap package, which parses binary data?

Yes.

> How is this all related to CIDER?

"This all" is not related to CIDER, because this is Logview's
implementation details. CIDER recently added some log-related functionality
and they'd like to use Logview as the base for their mode, as far as I
understand. They don't need datetime or extmap, but according to NonGNU
ELPA policy, Logview cannot be added without its dependencies.

> If possible, please add ".elpaignore" files to the repositories
themselves, so that we can void tracking the files in elpa-packages itself.

OK, I will do that if the packages get added to the archive. Don't want to
create files while I'm not sure they would be used for anything.

Paul

On Thu, 6 Jul 2023 at 19:59, Philip Kaludercic <philipk@posteo.net> wrote:

>
> "Bozhidar Batsov" <bozhidar@batsov.dev> writes:
>
> > Thanks for putting the patch together so quickly!
> >
> > Phillip, can you help us to get it applied?
>
> Applying the patch is not the issue, I am just personally hesitant to
> add a bunch of dependencies/packages I have never heard about before,
> more so because I don't use CIDER, /especially/ when I lack the time to
> properly review them (the argument that a package is "mature on MELPA"
> is rather weak from my experience, especially given the number of low
> quality packages on the archive).
>
> Without understanding the issue properly, why is there a need for an
> external data-time parsing package, if Emacs already comes with
> functions for parsing timestamps?  It appears to use use this extmap
> package, which parses binary data?  How is this all related to CIDER?
>
> But perhaps I am in a minority here, and we should just apply the patch.
>
> > On Thu, Jul 6, 2023, at 7:14 PM, Paul Pogonyshev wrote:
> >> Hi,
> >>
> >> Bozhidar Batsov, author and maintainer of CIDER, requested for
> >> package Logview to be made available on NonGNU ELPA:
> >> https://github.com/clojure-emacs/cider/issues/3365
> >>
> >> Since Logview has two dependencies itself, which are not available
> >> on NonGNU ELPA, and since Bozhidar assured me that it is fine to
> >> submit multiple packages in one go, the attached patch adds all
> >> three (Logview, datetime, extmap) at once. Local checks suggest that
> >> the packages can be built fine.
>
> I am a bit confused, why should adding multiple related packages in a
> single patch be an issue?
>
> >> All the packages have been available from MELPA for years and are
> >> mature projects. They are under active maintenance: even if I don't
> >> often add new features, I respond to reported issues on GitHub and
> >> write fixes when needed.
> >>
> >> I added directory `githooks' to the lists of exclusions even if it
> >> doesn't yet exist in the dependencies: I will add it there sooner or
> >> later anyway. In Logview itself this directory already exists.
>
> If possible, please add ".elpaignore" files to the repositories
> themselves, so that we can void tracking the files in elpa-packages
> itself.
>
> >> Please CC me on any replies, I'm not subscribed to the list.
>
> That is a given, don't worry about it.
>
> >> Paul
> >>
> >> *Attachments:*
> >>  • 0001-Add-Logview-with-dependencies.patch
>

[-- Attachment #2: Type: text/html, Size: 5047 bytes --]

Re: NonGNU ELPA: add Logview

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 4766 bytes --]

Yeah, CIDER recently introduced some functionality that uses Logview internally (see https://docs.cider.mx/cider/debugging/logging.html), that's why for us it's important for the package to be available on NonGNU ELPA. I think that Logview is a great and very useful package on its own, btw, so even without CIDER's immediate need I'd still advocate for its inclusion there.

Can't speak about Logview's deps (as I'm not familiar with them), but I know Paul is a great package maintainer, so I'm pretty sure that if he had to create some additional library there was a real need for it. 

On Thu, Jul 6, 2023, at 10:47 PM, Paul Pogonyshev wrote:
> > Without understanding the issue properly, why is there a need for an external data-time parsing package, if Emacs already comes with functions for parsing timestamps?
> 
> For speed. Logview is aimed at very large logs (megabytes) and also for lazily filtering them on-the-fly, adding/removing filters and so on. Built-in functions were not fast enough, so I had to create datetime. Also for matching: there is no standard timestamp format, the library helps me at building regexs needed to match timestamps in given format and also trying to guess which of many possible formats to use for a particular file.
> 
> I didn't create the library just for fun, I saw a need for it.
> 
> > It appears to use use this extmap package, which parses binary data?
> 
> Yes.
> 
> > How is this all related to CIDER?
> 
> "This all" is not related to CIDER, because this is Logview's implementation details. CIDER recently added some log-related functionality and they'd like to use Logview as the base for their mode, as far as I understand. They don't need datetime or extmap, but according to NonGNU ELPA policy, Logview cannot be added without its dependencies.
> 
> > If possible, please add ".elpaignore" files to the repositories themselves, so that we can void tracking the files in elpa-packages itself.
> 
> OK, I will do that if the packages get added to the archive. Don't want to create files while I'm not sure they would be used for anything.
> 
> Paul
> 
> On Thu, 6 Jul 2023 at 19:59, Philip Kaludercic <philipk@posteo.net> wrote:
>> 
>> "Bozhidar Batsov" <bozhidar@batsov.dev> writes:
>> 
>> > Thanks for putting the patch together so quickly!
>> >
>> > Phillip, can you help us to get it applied? 
>> 
>> Applying the patch is not the issue, I am just personally hesitant to
>> add a bunch of dependencies/packages I have never heard about before,
>> more so because I don't use CIDER, /especially/ when I lack the time to
>> properly review them (the argument that a package is "mature on MELPA"
>> is rather weak from my experience, especially given the number of low
>> quality packages on the archive).
>> 
>> Without understanding the issue properly, why is there a need for an
>> external data-time parsing package, if Emacs already comes with
>> functions for parsing timestamps?  It appears to use use this extmap
>> package, which parses binary data?  How is this all related to CIDER?
>> 
>> But perhaps I am in a minority here, and we should just apply the patch.
>> 
>> > On Thu, Jul 6, 2023, at 7:14 PM, Paul Pogonyshev wrote:
>> >> Hi,
>> >> 
>> >> Bozhidar Batsov, author and maintainer of CIDER, requested for
>> >> package Logview to be made available on NonGNU ELPA:
>> >> https://github.com/clojure-emacs/cider/issues/3365
>> >> 
>> >> Since Logview has two dependencies itself, which are not available
>> >> on NonGNU ELPA, and since Bozhidar assured me that it is fine to
>> >> submit multiple packages in one go, the attached patch adds all
>> >> three (Logview, datetime, extmap) at once. Local checks suggest that
>> >> the packages can be built fine.
>> 
>> I am a bit confused, why should adding multiple related packages in a
>> single patch be an issue?
>> 
>> >> All the packages have been available from MELPA for years and are
>> >> mature projects. They are under active maintenance: even if I don't
>> >> often add new features, I respond to reported issues on GitHub and
>> >> write fixes when needed.
>> >> 
>> >> I added directory `githooks' to the lists of exclusions even if it
>> >> doesn't yet exist in the dependencies: I will add it there sooner or
>> >> later anyway. In Logview itself this directory already exists.
>> 
>> If possible, please add ".elpaignore" files to the repositories
>> themselves, so that we can void tracking the files in elpa-packages
>> itself.
>> 
>> >> Please CC me on any replies, I'm not subscribed to the list.
>> 
>> That is a given, don't worry about it.
>> 
>> >> Paul
>> >> 
>> >> *Attachments:*
>> >>  • 0001-Add-Logview-with-dependencies.patch

[-- Attachment #2: Type: text/html, Size: 6681 bytes --]

Re: NonGNU ELPA: add Logview

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 5009 bytes --]

Just bumping this conversation, as we're still looking for someone to help us apply the patch. 

On Fri, Jul 7, 2023, at 8:21 AM, Bozhidar Batsov wrote:
> Yeah, CIDER recently introduced some functionality that uses Logview internally (see https://docs.cider.mx/cider/debugging/logging.html), that's why for us it's important for the package to be available on NonGNU ELPA. I think that Logview is a great and very useful package on its own, btw, so even without CIDER's immediate need I'd still advocate for its inclusion there.
> 
> Can't speak about Logview's deps (as I'm not familiar with them), but I know Paul is a great package maintainer, so I'm pretty sure that if he had to create some additional library there was a real need for it.
> 
> On Thu, Jul 6, 2023, at 10:47 PM, Paul Pogonyshev wrote:
>> > Without understanding the issue properly, why is there a need for an external data-time parsing package, if Emacs already comes with functions for parsing timestamps?
>> 
>> For speed. Logview is aimed at very large logs (megabytes) and also for lazily filtering them on-the-fly, adding/removing filters and so on. Built-in functions were not fast enough, so I had to create datetime. Also for matching: there is no standard timestamp format, the library helps me at building regexs needed to match timestamps in given format and also trying to guess which of many possible formats to use for a particular file.
>> 
>> I didn't create the library just for fun, I saw a need for it.
>> 
>> > It appears to use use this extmap package, which parses binary data?
>> 
>> Yes.
>> 
>> > How is this all related to CIDER?
>> 
>> "This all" is not related to CIDER, because this is Logview's implementation details. CIDER recently added some log-related functionality and they'd like to use Logview as the base for their mode, as far as I understand. They don't need datetime or extmap, but according to NonGNU ELPA policy, Logview cannot be added without its dependencies.
>> 
>> > If possible, please add ".elpaignore" files to the repositories themselves, so that we can void tracking the files in elpa-packages itself.
>> 
>> OK, I will do that if the packages get added to the archive. Don't want to create files while I'm not sure they would be used for anything.
>> 
>> Paul
>> 
>> On Thu, 6 Jul 2023 at 19:59, Philip Kaludercic <philipk@posteo.net> wrote:
>>> 
>>> "Bozhidar Batsov" <bozhidar@batsov.dev> writes:
>>> 
>>> > Thanks for putting the patch together so quickly!
>>> >
>>> > Phillip, can you help us to get it applied?
>>> 
>>> Applying the patch is not the issue, I am just personally hesitant to
>>> add a bunch of dependencies/packages I have never heard about before,
>>> more so because I don't use CIDER, /especially/ when I lack the time to
>>> properly review them (the argument that a package is "mature on MELPA"
>>> is rather weak from my experience, especially given the number of low
>>> quality packages on the archive).
>>> 
>>> Without understanding the issue properly, why is there a need for an
>>> external data-time parsing package, if Emacs already comes with
>>> functions for parsing timestamps?  It appears to use use this extmap
>>> package, which parses binary data?  How is this all related to CIDER?
>>> 
>>> But perhaps I am in a minority here, and we should just apply the patch.
>>> 
>>> > On Thu, Jul 6, 2023, at 7:14 PM, Paul Pogonyshev wrote:
>>> >> Hi,
>>> >>
>>> >> Bozhidar Batsov, author and maintainer of CIDER, requested for
>>> >> package Logview to be made available on NonGNU ELPA:
>>> >> https://github.com/clojure-emacs/cider/issues/3365
>>> >>
>>> >> Since Logview has two dependencies itself, which are not available
>>> >> on NonGNU ELPA, and since Bozhidar assured me that it is fine to
>>> >> submit multiple packages in one go, the attached patch adds all
>>> >> three (Logview, datetime, extmap) at once. Local checks suggest that
>>> >> the packages can be built fine.
>>> 
>>> I am a bit confused, why should adding multiple related packages in a
>>> single patch be an issue?
>>> 
>>> >> All the packages have been available from MELPA for years and are
>>> >> mature projects. They are under active maintenance: even if I don't
>>> >> often add new features, I respond to reported issues on GitHub and
>>> >> write fixes when needed.
>>> >>
>>> >> I added directory `githooks' to the lists of exclusions even if it
>>> >> doesn't yet exist in the dependencies: I will add it there sooner or
>>> >> later anyway. In Logview itself this directory already exists.
>>> 
>>> If possible, please add ".elpaignore" files to the repositories
>>> themselves, so that we can void tracking the files in elpa-packages
>>> itself.
>>> 
>>> >> Please CC me on any replies, I'm not subscribed to the list.
>>> 
>>> That is a given, don't worry about it.
>>> 
>>> >> Paul
>>> >>
>>> >> *Attachments:*
>>> >>  • 0001-Add-Logview-with-dependencies.patch
> 

[-- Attachment #2: Type: text/html, Size: 6897 bytes --]

Re: NonGNU ELPA: add Logview

[Philip Kaludercic]

"Bozhidar Batsov" <bozhidar@batsov.dev> writes:

> Just bumping this conversation, as we're still looking for someone to help us apply the patch. 

I was still waiting for comments from other people, as I haven't had the
time to review the packages myself.