From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: master 65108998b1e: docview: imenu: check return value of 'mutool' Date: Fri, 28 Jul 2023 06:56:30 +0200 Message-ID: <87jzuktyao.fsf@gnu.org> References: <168986904744.4030.15173437427788310246@vcs2.savannah.gnu.org> <20230720160407.BFFFAC06C66@vcs2.savannah.gnu.org> <86cz0dyytk.fsf@gnu.org> <83a5vhkvxq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1623"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.11.12; emacs 30.0.50 Cc: Arash Esbati , emacs-devel@gnu.org, Morgan.J.Smith@outlook.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 28 07:23:10 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPFwU-0000FQ-KE for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Jul 2023 07:23:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPFlq-0006Q8-60; Fri, 28 Jul 2023 01:12:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPFlm-0006Ps-F9 for emacs-devel@gnu.org; Fri, 28 Jul 2023 01:12:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPFlm-00052A-3S; Fri, 28 Jul 2023 01:12:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=VF3qhoEfjonnU3W67xvQUtT3wbY1HA2/Zzc1l3g0stc=; b=sLVhtKfBRIwZNa mF2vn00zQX7BmoNY6kxfvQZm9+5gGJsTOatWxlZJFTDeoAlj60SDo4jEObsg9+D+TXOCbh6IJkZry RZncLCrKyeFNDZKEzyQFuhJuWuTO54IxboilzZ9oKNKBfFEihE2ECTlKk1t42BJHh4ZN4MJMt/Ceq 7153u98k6ZJlRdpPc2ZQMM7hDjwh+bnemGUNkkq8VttAWJMTigDPT4NtoheohLRk3vchY5v/061nv sAZFtKRo/efVUQIN+sYOWg/1FRkc3InB2HJmZP6EBtk0GoeDh1RctLAUSdCsFCccfSeFeCUi7MGxu bfToRFoeWQ9fyrwkX2sA==; Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPFll-0004p9-NB; Fri, 28 Jul 2023 01:12:05 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id E902F27C0054; Fri, 28 Jul 2023 01:12:02 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 28 Jul 2023 01:12:02 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieehgdeltdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepud ejtdehuddvleffjeekteegvdehleehvdeufefhueekkeekhedvgfeggeffvefgnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Jul 2023 01:12:01 -0400 (EDT) In-reply-to: <83a5vhkvxq.fsf@gnu.org> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308180 Archived-At: Eli Zaretskii writes: >> > +(defcustom doc-view-imenu-enabled (executable-find "mutool") >> > "Whether to generate an imenu outline when \"mutool\" is available." >> > :type 'boolean >> > :version "29.1") >> >> I'm not familiar with the code, so my apologies if this comment is >> off, but the change above seems wrong. With this change, >> `doc-view-imenu-enabled' becomes a string or nil which doesn't match >> the boolean type. The (and ... t) part wasn't superfluous. > > This was okayed by Tassilo, so I'm adding him to this discussion. Oh, I've not just okayed but actually smuggled in this logical simplification into Morgan's patch which is obviously not correct in this specific place. I've just fixed it on master. Thanks for the heads-up and apologies, especially to Morgan. Bye, Tassilo