From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: jami-bot and org-jami-bot Date: Mon, 15 Jan 2024 07:06:22 +0000 Message-ID: <87jzobxehd.fsf@posteo.net> References: <875y0i7e43.fsf@hoowl.se> <87y1cyqoso.fsf@posteo.net> <87cyu3aftq.fsf@hoowl.se> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39468"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , emacs-devel@gnu.org To: Hanno Perrey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 15 08:07:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rPH44-000A53-Ij for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Jan 2024 08:07:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rPH3J-0006gp-M6; Mon, 15 Jan 2024 02:06:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPH3I-0006gX-RU for emacs-devel@gnu.org; Mon, 15 Jan 2024 02:06:32 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPH3G-0004Es-BZ for emacs-devel@gnu.org; Mon, 15 Jan 2024 02:06:32 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0B1AD240028 for ; Mon, 15 Jan 2024 08:06:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1705302385; bh=BgVp7diAwSOn7sXlRtEQDJgJpDU7HZi4OV4V4ZInEyg=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: From; b=CF1+QXyA70P16+WgechT9y+FsGwo4Q4tphKqdDCvvY9xDpG86N+DSbQ7/+X7GAdx5 PFP8OmIG5YrlArE4ypnlGcJMYIArK7qD5DPayhCWJvLY8I/t0QDIXQTdID94W6mNL8 1tTWq/5WoRn5HyTpNBMrAqaKzyw7iuJyxONMB6pJYXEHBR9UTl2vNGyRbqirYdPSzV Y42RV+dmkzGV0adRPpT8sEKz991NLEi8yBUCNtRIO5Iyv/5BBdXea/zKxT+Er+LnWt E/iw6E2MImQfCHz0naQtfju1me4mrx2YjONDDJWZsVizPanFPtZokmL2FskmId363o Q+GQ8Dbu9UphQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TD38b6tBCz9rxL; Mon, 15 Jan 2024 08:06:23 +0100 (CET) In-Reply-To: <87cyu3aftq.fsf@hoowl.se> (Hanno Perrey's message of "Sun, 14 Jan 2024 19:46:07 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314983 Archived-At: --=-=-= Content-Type: text/plain Hanno Perrey writes: > Hej Philip, > > I have now modified the code according to your suggestions and pushed > the changes. [...] The sharp-quoting was my mistake, I misread the hooks as functions. Other than that, here is a diff with the remaining changes I would propose: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/jami-bot.el b/jami-bot.el index 8ad3ed0..5ea9aad 100644 --- a/jami-bot.el +++ b/jami-bot.el @@ -1,6 +1,6 @@ ;;; jami-bot.el --- An extendable chat bot for the private messenger GNU Jami -*- lexical-binding: t; -*- -;; Copyright (C) 2023 Free Software Foundation, Inc. +;; Copyright (C) 2023, 2024 Free Software Foundation, Inc. ;; Author: Hanno Perrey ;; Maintainer: Hanno Perrey @@ -73,14 +73,14 @@ consist of a single (lowercase) word. The corresponding function needs to accept the account id, the conversation id and the message alist as arguments and return a string (that is sent as reply to the original message)." :group 'jami-bot - :type '(alist :key-type 'string :value-type 'function)) + :type '(alist :key-type string :value-type function)) (defcustom jami-bot-text-message-functions nil "A list of functions that will be called when processing a plain text message. Functions must take the ACCOUNT and CONVERSATION ids as well as the actual MSG as arguments. Their return value will be ignored." :group 'jami-bot - :type '(group 'function)) + :type '(group function)) (defcustom jami-bot-download-path "~/jami/" "Path in which to store files downloaded from conversations. @@ -95,9 +95,9 @@ Functions must take the ACCOUNT and CONVERSATION ids as well as the actual MSG and the local downloaded file name, DLNAME, as arguments. Their return value will be ignored." :group 'jami-bot - :type '(group 'function)) + :type '(group function)) -;; Internal variables +;;;; Internal variables (defvar jami-bot--jami-local-account-ids nil "List of `jami' local accounts user ids and name pairs. @@ -105,7 +105,7 @@ arguments. Their return value will be ignored." Caches output of dbus-methods \"getAccountList\" and \"getAccountDetails\". For internal use in `jami-bot'.") -;; Functions +;;;; Functions (defun jami-bot--messageReceived-handler (account conversation msg) "Handle messages from Jami's `messageReceived' D-Bus signal. @@ -254,7 +254,9 @@ corresponding ids to which the message MSG belongs to." (filename (cadr (assoc-string "displayName" msg))) (dlpath (file-name-as-directory (expand-file-name jami-bot-download-path))) - (dlname (concat dlpath (format-time-string "%Y%m%d-%H%M") "_" filename))) + (dlname (expand-file-name + (concat (format-time-string "%Y%m%d-%H%M") "_" filename) + dlpath))) (unless (file-directory-p dlpath) (make-directory dlpath 't)) (message "jami-bot: downloading file %s" dlname) (jami-bot--dbus-cfgmgr-call-method "downloadFile" account conversation id fileid dlname) --=-=-= Content-Type: text/plain > Thanks again for the feedback! > > Best wishes, > Hanno --=-=-=--