From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: raman@google.com, emacs-devel@gnu.org
Subject: Re: Faces for strong, emph and friends in Info?
Date: Tue, 09 Apr 2024 11:01:49 +0200 [thread overview]
Message-ID: <87jzl6syde.fsf@gmail.com> (raw)
In-Reply-To: <86jzl7yajk.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 08 Apr 2024 21:27:43 +0300")
>>>>> On Mon, 08 Apr 2024 21:27:43 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: "T.V Raman" <raman@google.com>, emacs-devel@gnu.org
>> Date: Mon, 08 Apr 2024 18:57:10 +0200
>>
Eli> I think it's just that no one has written the code to show *foo* and
Eli> _foo_ as italics and bold (and hide the _ and * characters). Of
Eli> course, this will cause some lines be shorter or longer than they are
Eli> supposed to be, but maybe this is a worthwhile price to pay.
>>
Eli> Patches welcome.
>>
>> How robust do you want this to be?
Eli> As robust as possible, of course.
>> +(defface Info-strong
>> + '((t :inherit bold))
>> + "Face used for *strong* elements."
>> + :version "30.1")
Eli> We need fallback for terminals that don't support bold. Some
Eli> stand-out color, perhaps?
I guess. Let me see if I can plagiarize^W seek inspiration from eg
Gnus, that has all sorts of angry fruit salad stuff
Eli> Also, the doc string should mention Info mode.
>> + (while (re-search-forward "\\([*_]\\)\\([^*_\n]+\\)\\([*_]\\)" nil t)
Eli> This is too fragile, I think. It matches stuff like "*Note foo_",
Eli> which can happen in cross-references, for example. Also, what if
Eli> @emph or @strong spans a newline?
Yes, would need fixing. I donʼt think emacs regexp search supports
backreferences, so it will be less elegant.
Regarding newlines, do you have an example? It could be added, but Iʼm
not sure if we want to pay the price of excessive searching (although
this code is run only once per node).
Robert
--
next prev parent reply other threads:[~2024-04-09 9:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 14:49 Faces for strong, emph and friends in Info? T.V Raman
2024-04-08 14:59 ` Eli Zaretskii
2024-04-08 16:57 ` Robert Pluim
2024-04-08 17:28 ` T.V Raman
2024-04-08 18:06 ` [External] : " Drew Adams
2024-04-08 18:27 ` Eli Zaretskii
2024-04-08 19:32 ` [External] : " Drew Adams
2024-04-09 9:01 ` Robert Pluim [this message]
2024-04-09 9:56 ` Eli Zaretskii
2024-04-10 16:11 ` Robert Pluim
2024-04-10 16:17 ` T.V Raman
2024-04-10 16:27 ` Robert Pluim
2024-04-10 16:53 ` Eli Zaretskii
2024-04-11 12:59 ` Robert Pluim
2024-04-11 14:10 ` T.V Raman
2024-04-10 16:51 ` Eli Zaretskii
2024-04-08 22:02 ` T.V Raman
2024-04-08 22:29 ` T.V Raman
2024-04-09 1:47 ` [External] : " Drew Adams
2024-04-09 2:23 ` T.V Raman
2024-04-09 4:22 ` Eli Zaretskii
2024-04-09 1:35 ` T.V Raman
2024-04-09 4:21 ` Eli Zaretskii
2024-04-09 13:29 ` T.V Raman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzl6syde.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=raman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).