Re: Submitting Dslide to Non-GNU ELPA

[Philip Kaludercic <philipk@posteo.net>]

Psionic K <psionik@positron.solutions> writes:

>> administrative suggestions
>
> Looks good.  Applying.
>
>> what to use for the package description.
>
> New first paragraph of my package comments looks okay for this?
>
> ;; DSL IDE builds presentations on top of org mode documents.  It integrates
> ;; with arbitrary buffers and org babel, making anything Emacs can do easy to
> ;; incorporate into a presentation.  Headers are configured with extensible
> ;; actions.  Custom steps can be scripted with babel blocks or made into
> ;; reusable custom actions.  DSL IDE achieves a good result with no preparation
> ;; but can achieve anything Emacs can display if you need it to.

LGTM

>> Also, you mention an Info manual, but I didn't find anything besides
>> doc/README.org.  Is that supposed to be installed as the manual?
>
> I didn't get around to that yet.  I intend to break up the readme and
> export a texinfo to /doc/dslide.texi.  IIRC this location is compatible
> with ELPA package archives.

ELPA will not automatically choose some path to use for the
documentation.  Instead we have to explicitly give some path in the
package specification.  This can be a .org file as well, that the build
server will compile to a .texi and then an .info file.

Psionic K <psionik@positron.solutions> writes:

> I pushed updates.  I declined two changes and wanted to point them out:
>
>>  (defun dslide--list-item-contains (item loc)
>> -  (when item
>> -    (let ((beg (car item))
>> -          (end (car (last item))))
>> -      (and  (>= loc beg)
>> -            (< loc end)))))
>> +  (and item (<= (car item) loc (+ (car (last item))))))
>
> I omitted the call to `+'.  No idea what it could do there.  `item' is an
> org item, which will always contain an integer in this situation.

That was a typo, I meant to use (1+ ...), since we have now replaced the
(< loc end) with a (<= loc end), which is not correct, while (< loc (1+
end)) is.

> I did not use `message--max' because it produced a compiler warning.

Here as well, I believe that was a failed experiment, where I just
removed the log from message-log-max.  Ignore that.

> If either of these are still recommended, just let me know.

-- 
	Philip Kaludercic on peregrine