Re: having emacs-matlab in ELPA, finally. FSF paper signed

[Uwe Brauer <oub@mat.ucm.es>]

[-- Attachment #1: Type: text/plain, Size: 3002 bytes --]

>>> "SK" == Stefan Kangas <stefankangas@gmail.com> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>>>>> "SK" == Stefan Kangas <stefankangas@gmail.com> writes:
>> 
>>> Philip Kaludercic <philipk@posteo.net> writes:
>>> +(defconst matlab-mode-version (package-get-version)
>>> +  "Current version of MATLAB(R) mode.")
>> 
>>> We have tried to discourage the addition of such variables and commands,
>>> given that one can always find that information by other means,
>>> e.g. interactively with `describe-package` or from Lisp:
>> 
>>> (package-desc-version (cadr (assq 'foo package-alist)))
>> 
>> So you want me use just that string
>> well (package-desc-version (cadr (assq 'matlab-mode package-alist)))
>> I presume
>> 
>> in matlab.el (and matlab-mode.el)?

> That's what I would do, indeed.  Well, I'd use this if you need the
> string form:

>     (package-version-join
>      (package-desc-version (cadr (assq 'matlab-mode package-alist))))

Just to be sure, in both files, matlab.el and and matlab-mode.el?



>> What's about our current setting
>> 
>> (defconst matlab-mode-version "6.2"
>> "Current version of MATLAB(R) mode.")
>> 
>> Which we need for MELPA?

> Hmm, are you sure that you need it for MELPA even with the addition of
> the "Version" header?

> In any case, this is an extremely minor nit either way.


Ok, a last question then, as Philip wrote 

,----
| * As soon as it works.  The main issues right now, are as you noticed
|   that ELPA doesn't release a new tarball for every commit, but just
|   when a new version is released.  We track this by checking for commits
|   that bump the "Version" header in the main file (in your case
|   matlab.el).  You currently don't have any version number, so the build
|   fails.  I would suggest applying a change like this, if it doesn't
|   break any assumptions you have regarding the minimal Emacs version:
`----

But what is meant by «bump the Version header"
since this header somehow seems to be determined by 
     (package-version-join
      (package-desc-version (cadr (assq 'matlab-mode package-alist))))

But if I run eval-sexep this returns 
"20191223.2012"


So I don't see any place where I manually change the Version header. Or
are we talking about adding a (git) tag?

I guess I need something  like this (stolen from auctex, who BTW use 😉
,----
| (defconst AUCTeX-version (package-get-version)
|   "AUCTeX version.")
`----


;;; matlab.el --- major mode for MATLAB(R) dot-m files -*- lexical-binding: t -*-

;; Copyright (C) 2014-2024 Free Software Foundation, Inc.

;; Version: 6.2
;; URL: https://www.gnu.org/software/auctex/
;; Author: Matt Wette <mwette@alumni.caltech.edu>,
;;         Eric M. Ludlam <eludlam@mathworks.com>
;; Maintainer: Uwe Brauer <oub@mat.ucm.es>,
;;             Eric M. Ludlam  <eludlam@mathworks.com> 
;; Package-Requires: ((emacs "27.1"))
;; Created: 04 Jan 91
;; Keywords: MATLAB(R)


Uwe 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5684 bytes --]