From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] new package: eglot-inactive-regions Date: Fri, 06 Dec 2024 09:00:31 +0000 Message-ID: <87jzcd2nkg.fsf@posteo.net> References: <874j3nrri7.fsf@posteo.net> <878qswlfty.fsf@posteo.net> <87ldwvjdzl.fsf@posteo.net> <878qsu3zln.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24445"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Gerd =?utf-8?Q?M=C3=B6llmann?= , Stefan Kangas , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Filippo Argiolas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 06 10:01:34 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJUDN-0006DD-Mi for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Dec 2024 10:01:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJUCe-0004jK-6w; Fri, 06 Dec 2024 04:00:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJUCa-0004ik-PH for emacs-devel@gnu.org; Fri, 06 Dec 2024 04:00:44 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJUCW-000440-Fk for emacs-devel@gnu.org; Fri, 06 Dec 2024 04:00:43 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 03BD6240029 for ; Fri, 6 Dec 2024 10:00:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1733475638; bh=CYVkLDwxCyRiZJ6xHaKttTThKvJbtCLa3MJu9JNJbMA=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=ZjIv3IOFcxuCCHRKeFN7u5T2AUb6NaQH4idNYtGgoSgrHi064dkWB4FfChxLyqctU IPLoumLsI8UCxWZLg5lElP4b9SowJ1IRjZ6+c8X5lO3WxIzvJ25c/S/LE9iGpqCbQ6 iKy/ruX2e5uFpCLjSjJTu5/IQCpQ9efxMeVOr4Qhc2uclcch7F3RZmNH5vXkrDCn2+ 2iW5LQVEm7XJdBNIQ+rjkWI4EbBRB9EToxB0yS/gpn6DdgLJXGl5B2iRdNnhPJagic v8RhG9E278CDaPH8qScWv2q98Sc8GKBtk+YRw8+nvb95flL/lFJAyfp0nmm8HqAi3m 7EcJZo9SJIGDA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Y4QFx1GSHz6tvx; Fri, 6 Dec 2024 10:00:37 +0100 (CET) In-Reply-To: (Filippo Argiolas's message of "Thu, 05 Dec 2024 22:19:56 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326125 Archived-At: Filippo Argiolas writes: > Philip Kaludercic writes: > >> Filippo Argiolas writes: >> >>> Philip Kaludercic writes: >>> >>>> Filippo Argiolas writes: >>>> >>>>> Filippo Argiolas writes: >>>>> >>>>>> Philip Kaludercic writes: >>>>>> >>>>>>> I would try something of the form like >>>>>>> >>>>>>> (if (fboundp 'new-function) >>>>>>> (new-function ...) >>>>>>> (old-function ...)) >>>>>>> >>>>>>> If on the other hand there has already been a new release of Eglot = with >>>>>>> these commands, then just depend on that version and the issue would >>>>>>> resolve itself. >>>>>>> >>>>>> >>>>>> CC-ing Jo=C3=A3o. >>>>>> >>>>>> I pushed the suggested change but I still get the compile warnings a= bout >>>>>> deprecated functions. I'd like to keep supporting emacs-29, should I >>>>>> just disregard the warning? >>>>>> >>>>>> Sorry for the ignorance, how would the dependency on a specific eglot >>>>>> version work now that it's in core? >>>>>> Does it require the users to have additional repos enabled? >>>>>> >>>>>> Sounds strange to me that we have macros to deprecate functions but = no >>>>>> mechanism to automatically switch to the new one if it's just a >>>>>> rename. Am I missing something obvious? >>>>>> >>>>>> Thanks! >>>>>> >>>>>> Filippo >>>>> >>>>> How about something like: >>>>> >>>>> ;; fallback to deprecated eglot functions >>>>> (when (version< emacs-version "30") >>>>> (defalias 'eglot-uri-to-path 'eglot--uri-to-path) >>>>> (defalias 'eglot-range-region 'eglot--range-region)) >>>>> >>>>> or even something similar with a check on eglot version? >>>> >>>> That can be dangerous if other packages do fboundp checks and infer too >>>> much from that. I would try to see if adding `declare-function's could >>>> help suppress the warnings? >>> >>> Nope, the only solution working so far is to call the deprecated >>> functions with `with-no-warnings'. >>> >>> Guess I'll go with this. I'd be fine with the warnings too if we didn't >>> have the annoying habit of scaring the end users with them :-) >> >> I don't have your source code available right now, my last suggestion >> would be to use `with-suppressed-warnings' where you can suppress >> specific obsoletion warnings, but that requires Emacs 27.1 or newer. >> > > Thanks this seems to do the trick! OK great, I'll add the package to NonGNU ELPA. Can you just add a .elpaignore file that lists the "screenshot" directory to be excluded from the tarball? PS. Using the command "oxipng -o max -Z" I could compress one of the images by 49%. You might also consider creating a SVG screenshot.